Skip to content

Add damage threshold for grenade explosions and container spills #39260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add damage threshold for grenade explosions and container spills #39260

wants to merge 3 commits into from
+46 −1

Conversation

B-Kirill
Copy link
Contributor

About the PR

This PR contains these changes:

  • Containers with liquids will not spill liquids with heavy damage (200 damage) (hope I did not miss any)
  • Grenades will not activate with huge damage (1000 damage)
  • A small bugfix of the sound of breaking a wooden table (not related to this PR, just noticed)

Why / Balance

Optimization

Media

It just works

Requirements

Changelog
Not that important, I suppose?

@PJBot PJBot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Jul 28, 2025
@github-actions github-actions bot added the size/M Denotes a PR that changes 100-999 lines. label Jul 28, 2025
@K-Dynamic
Copy link
Contributor

Yeah I can get behind dense explosions vaporising (deleting) solutions

@iaada iaada added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Aug 4, 2025
@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@PJBot PJBot added size/L Denotes a PR that changes 1000-4999 lines. and removed size/M Denotes a PR that changes 100-999 lines. labels Oct 21, 2025
@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Oct 21, 2025
@PJBot PJBot added size/S Denotes a PR that changes 10-99 lines. and removed size/L Denotes a PR that changes 1000-4999 lines. labels Oct 21, 2025
@B-Kirill
Copy link
Contributor Author

Okay, everything seems to be done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines. T: New Feature Type: New feature or content, or extending existing content

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@B-Kirill @K-Dynamic @PJBot @iaada