Skip to content

Conversation

K-Dynamic
Copy link
Contributor

@K-Dynamic K-Dynamic commented Jul 28, 2025

About the PR

  • Adds Transform component to AI core with noRot set to true
  • Removes Transform component from BaseCharger, which is already inherited from BaseMachinePowered

Why / Balance

Seemed out of place that AI cores and chargers are able to rotate compared to other machines.

Borg chargers and AI cores should now be much easier to drag through 1-tile wide passages.

Technical details

N/A

Media

AI Core

dotnet_vCni9O8Vq1

Chargers

dotnet_TFx4MiOH84

Requirements

Breaking changes

N/A

Changelog

  • tweak: AI core and chargers now automatically rotates to grid cardinal direction, making them easier to drag through doors if dislodged.

@K-Dynamic K-Dynamic requested a review from DrSmugleaf as a code owner July 28, 2025 05:12
@PJBot PJBot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jul 28, 2025
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 28, 2025
@K-Dynamic K-Dynamic changed the title Make AI core easier to drag through 1-tile wide passages Makes AI core and chargers easier to drag through 1-tile wide passages Jul 28, 2025
@metalgearsloth
Copy link
Contributor

Unanchorable ents really shouldn't have this.

@K-Dynamic
Copy link
Contributor Author

Test fail is real but I'm a bit confused what it actually means

@lzk228
Copy link
Contributor

lzk228 commented Jul 28, 2025

i suppose you also could fix this in your pr
#27116

@slarticodefast
Copy link
Member

Unanchorable ents really shouldn't have this.

Yeah, I agree. It looks weird when you throw it into space and it suddenly changes orientation when leaving the grid.

@slarticodefast slarticodefast added the S: Concern A maintainer has raised concerns regarding the idea. The PR may be closed by another maintainer. label Jul 28, 2025
@K-Dynamic
Copy link
Contributor Author

Yeah, I agree. It looks weird when you throw it into space and it suddenly changes orientation when leaving the grid.

I'm not sure what the problem is here since virtually every machine with noRot: true will do this (lathes, microwaves, vendors, etc.)

@slarticodefast
Copy link
Member

I guess it's consistent with other structures, but I still think it looks bad when you throw it into space and it suddenly snaps into another direction.
An alternative would be to make the fixture slightly smaller so it can be pulled through airlocks, or make pulling less jank with rotations.
But I'll let someone else decide.

@slarticodefast slarticodefast removed the S: Concern A maintainer has raised concerns regarding the idea. The PR may be closed by another maintainer. label Jul 28, 2025
@K-Dynamic
Copy link
Contributor Author

I guess it's consistent with other structures, but I still think it looks bad when you throw it into space and it suddenly snaps into another direction. An alternative would be to make the fixture slightly smaller so it can be pulled through airlocks, or make pulling less jank with rotations. But I'll let someone else decide.

It's kinda necessary for AI core and machines in general to have noRot since they can get dislodged without any means of finely rotating them to grid cardinal directions. I'll open an issue regarding noRot later since there's some odd behaviour though.

@southbridge-fur
Copy link
Contributor

It's kinda necessary for AI core and machines in general to have noRot since they can get dislodged without any means of finely rotating them to grid cardinal directions. I'll open an issue regarding noRot later since there's some odd behaviour though.

Anchoring will snap them to the nearest grid cardinal direction. That's how I've always managed to make the Borg chargers behave so they got through doorways. That being said I totally agree this is a good change although I feel like we'll lose some of the humor in nukies awkwardly dragging the AI core around to get rid of it though.

As for the test fail, you may need to go through each map file (or at least Relic it seems?) and ensure to remove the rotation on the Borg chargers.

@notquitehadouken
Copy link
Contributor

As for the test fail, you may need to go through each map file (or at least Relic it seems?) and ensure to remove the rotation on the Borg chargers.

it's Regex time

@ToastEnjoyer ToastEnjoyer added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Aug 4, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/XS Denotes a PR that changes 0-9 lines. T: New Feature Type: New feature or content, or extending existing content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants