Skip to content

Conversation

DDeegan
Copy link
Contributor

@DDeegan DDeegan commented Jul 28, 2025

About the PR

Gives all mobs the ability to emote, and lets several animals make various sounds.

Why / Balance

As it stands, many animals do not have an inherent ability to emote or vocalize. This wasn't an issue previously, since any effect that allowed players to control animals also let them communicate, but this is not the case for the Wizard's mindswap spell. Multiple times, I've seen players frustrated by being swapped into Renault, or Bandito, or other animals, and not having any way to communicate.

Technical details

Adds an Emoting component to base.yml
Adds Speech and ReplacementAccent components to most entries in animals.yml
Adds a new accent (Cow) to full_replacements.yml and accents.ftl

Media

image

Requirements

Changelog

🆑

  • tweak: Gave several animals the ability to emote and make sounds.

@PJBot PJBot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. labels Jul 28, 2025
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-99 lines. label Jul 28, 2025
@K-Dynamic
Copy link
Contributor

I think this is significant enough to warrant a changelog

Also your PR title should be changed

@DDeegan DDeegan changed the title Wizden master Animal Emotes/Accents Jul 28, 2025
@DDeegan
Copy link
Contributor Author

DDeegan commented Jul 28, 2025

I think this is significant enough to warrant a changelog

Also your PR title should be changed

Updated, thanks! Sorry, I had originally backed out of creating the PR to get a little screenshot, and forgot to add the title when I restarted. And the changelog was accidentally within the example comment.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jul 30, 2025
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jul 31, 2025
@iaada iaada added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Character/Species Area: Player characters and species features and content. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Aug 4, 2025
Copy link
Contributor

@TrixxedHeart TrixxedHeart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only thing I have any issue with. Otherwise all the YML appears to be in correct format

Comment on lines +1087 to +1088
- type: ReplacementAccent
accent: cow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like goats shouldn't moo, it's more like sheep sounds like baaa and maah

Copy link
Contributor Author

@DDeegan DDeegan Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured it would be best to avoid adding any more accents than I absolutely had to, but I can toss in a sheep accent if you think that'd be a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: Character/Species Area: Player characters and species features and content. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines. T: New Feature Type: New feature or content, or extending existing content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants