Factor out door bolts from DoorSystem into BoltSystem #39247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, not just a locstring. Take the random default BaseTime out of the GetPryTimeModifierEvent, this default was never used. BaseTime is set at construction of the event from PryableComponent instead of an event on PryableComponent. Use `Entity<T>` for OnDoorAltVerb, OnDoAfter Use `Resolve` on nullable component arguments in public functions. Use `Entity<T>` pattern in private functions Add some comments and change some variable names in `PryingSystem for clarity.`
fix high sec door not being pryable fix blast door being pryable
…em.cs` - Change `DoorRemoteSystem` to work with `DoorBoltComponent` directly, without required a `DoorComponent` - Remove requirement for `DoorComponent` from `SharedDoorSystem.HasAccess(...)` making it a target for future access checking refactor - Add a flag to `DoorBoltComponent` to allow bolts and the bolt indicator to work without being powered (for future turnstile work) - Add a `BeforeBoltEvent` to allow cancellation of bolting besides power (for future turnstile work) - Add a `PassagewayAccessRequest` event to check for oddball access overrides like on firelocks and emergency access doors - Remove `SetBoltsDown` because it's literally just `TrySetBoltsDown` without a return value - Generalize some localizations to use the entity's name
…pen, pry closed, powered, unpowered, welded, unwelded, hand pry, crowbar, jaws of life.
This reverts commit a512578.
PJBot
added
S: Needs Review
VerinSenpai
added
D1: High
github-actions
bot
added
the
S: Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
NOTE: THIS DEPENDS ON #37689
I've taken most of the code from
SharedDoorSystem.Boltsand put it into aSharedBoltSystem.This should pave the way to allowing door bolts or bolt-like attributes to other entities like turnstiles.
There's also a new datafield that is currently unused but will be used for turnstiles
BoltsRequirePower.Setting this to false will allow bolts to actuate and the bolt indicators to show without the entity being powered.
Why / Balance
Code refactor, atomizing PRs leading to full implementation of #37350.
Technical details
It should hopefully be relatively obvious what I pull out of
DoorSystem.Boltsand how it fits together.I've also added a
PassagewayAccessRequestevent to remove hardcoded component dependencies such asAirlockComponentfor emergency access mode andFirelockComponentfor firelock access. This event is raised inSharedDoorSystem.HasAccess.Media
No media
Requirements
Breaking changes
All functions from
SharedDoorSystem.Boltsand been moved intoSharedBoltSystemSharedDoorSystem.HasAccessno longer takesDoorComponentargument.SetBoltsDownhas been removed, just useTrySetBoltsDownand ignore the return.