Skip to content

last words error fix #39245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2025
Merged

last words error fix #39245

merged 1 commit into from
Jul 28, 2025
+4 −0

Conversation

@xsainteer
Copy link
Contributor

About the PR

If a person is gibbed and still has "last words" dialog opened and decides to execute it, the error won't appear

Why / Balance

Technical details

4 line bugfix

Media

Closes #39180

Requirements

Breaking changes

Changelog

@PJBot PJBot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jul 27, 2025
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 27, 2025
@xsainteer xsainteer changed the title 4 line bugfix last words error fix Jul 27, 2025
@slarticodefast slarticodefast added T: Bugfix Type: Bugs and/or bugfixes A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jul 28, 2025
slarticodefast
slarticodefast approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as indended! Thanks for the bugfix!

@PJBot PJBot added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Jul 28, 2025
@slarticodefast slarticodefast merged commit 901cef4 into space-wizards:master Jul 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slarticodefast slarticodefast slarticodefast approved these changes

Assignees

No one assigned

Labels

A: General Interactions Area: General in-game interactions that don't relate to another area. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/XS Denotes a PR that changes 0-9 lines. T: Bugfix Type: Bugs and/or bugfixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Saying last words after you have been gibbed causes an error

3 participants

@xsainteer @slarticodefast @PJBot