Prevent Divide by Zero error with Stamina Animation on Aberrant Flesh #39235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PJBot
added
S: Needs Review
ScarKy0
reviewed
Jul 27, 2025
2 tasks
|
Good fix! These are the mobs that currently cause this error. Could you please make sure they're all fixed by this PR?
|
Done, all the flesh golems inherited from two prototypes that were already fixed, leaving just the tick and bees to be fixed. |
Tayrtahn
approved these changes
Jul 27, 2025
PJBot
added
S: Approved
Tayrtahn
reviewed
Jul 30, 2025
Princess-Cheeseballs
requested review from
ScarKy0,
Tayrtahn and
slarticodefast
Tayrtahn
approved these changes
Aug 1, 2025
* Scurrets - spacing protection via adorable outfits * ALPHABETIZATION!!
* catching * fix * improve * fix linter * cleanup * fix prediction * do the same here * fix comment
Reducing the amount of space in the hat from 7*4 to 4*3 to make a bit more sense with the fact it is only a hat. Co-authored-by: ArtisticRoomba <[email protected]>
* Golden pai * Make golden PAI public and rare * Golden PAI = legendary salvage
This reverts commit e9c90fe. Please check the maintainer meeting for details
…c blade for Nukies (space-wizards#37182)" This reverts commit c03afeb. Please check the maintainer meeting for details
Co-authored-by: slarticodefast <[email protected]>
Co-authored-by: Princess Cheeseballs <[email protected]>
…ds#39153) * test one, the light is not showing for some reason * ToggleableVisuals, not ToggleableLightVisuals * FIX THIS AGAIN I AM STUPID * WHY DID THESE PERSIST =(
Co-authored-by: slarticodefast <[email protected]>
…s#39025) * feat: add a component for rejuvenateable effects * feat: let god mode'd entities get buffs * fix: handle old status effect system Didn't realize BeforeStatusEffectAddedEvent was called by both systems, oops. * refactor: rename to RejuvenateRemovedStatusEffect * fix: make forced sleeping a debuff again Missed in rebase. * refactor: make BeforeStatusEffectAdded two events
…lesh-stun-animation-fix # Conflicts: # Content.Client/Damage/Systems/StaminaSystem.cs
Princess-Cheeseballs
requested review from
DrSmugleaf,
TheShuEd,
crazybrain23 and
metalgearsloth
as code owners
PJBot
added
Changes: Sprites
|
Ah fuck it just gonna redo the branch |
This was referenced Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
68 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Fixed and added checks for a divide by zero error on Aberrant flesh.
Fixes #39234
Why / Balance
Divide by zero bad.
Technical details
Changed the animationThreshold for abberant flesh to not be the same as its crit threshold.
Added an error check in the Stamina Animation to make sure that the Animation threshold is always less than the crit threshold.
Media
Requirements
Breaking changes
Changelog