Skip to content

Conversation

@ScholarNZL
Copy link
Contributor

@ScholarNZL ScholarNZL commented Jul 26, 2025

About the PR

In:

  • Resources\Prototypes\Body\Organs\Animal\animal.yml
  • Resources\Prototypes\Body\Organs\Animal\bloodsucker.yml
  • Resources\Prototypes\Body\Organs\arachnid.yml

Updated IC titles to reflect animal / humanoid organs, so Kitchen have a better time making more unique food.

Edited this: Removed IC titles to inherit from parent entities, which achieves the same outcome.

Why / Balance

Resolves #38980.

Ensures clear differentiation between animal hearts and non-animal (Humanoid) hearts, and other organs.

Technical details

All organs in the above three files have the name element in the yaml prefixed with "animal ", where the parent or id is prefixed by OrganAnimal.

Edited this: Removed IC titles to inherit from parent entities, which achieves the same outcome.

Media

Changes demonstrated here (Sorry, Pun-Pun.)
2025-07-27 10-38-53

Requirements

Breaking changes

Changelog

🆑

  • tweak: Added IC visibility of "animal organs", e.g "animal lungs" etc, to facilitate recipe creation.

@ScholarNZL ScholarNZL requested a review from DrSmugleaf as a code owner July 26, 2025 22:45
@PJBot PJBot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jul 26, 2025
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-99 lines. label Jul 26, 2025
@ScholarNZL
Copy link
Contributor Author

ScholarNZL commented Jul 26, 2025

I updated the PR Description to include the changelog notes, as I didn't format this correctly originally.
May need a re-run of the appropriate CI check, or a re-run of the appropriate mechanism to have it included.

@ScholarNZL
Copy link
Contributor Author

On further review, noticed Arachnid types also have a animal stomach component.
Updated as appropriate.

@VerinSenpai VerinSenpai added DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. A: Character/Species Area: Player characters and species features and content. T: Chore Type: Some procedure that has to be done to the project. T: Cleanup Type: Code clean-up, without being a full refactor or feature and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. T: Chore Type: Some procedure that has to be done to the project. labels Aug 4, 2025
Copy link
Member

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@PJBot PJBot added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Aug 15, 2025
@beck-thompson beck-thompson merged commit d4f50c7 into space-wizards:master Aug 15, 2025
10 checks passed
@ScholarNZL ScholarNZL deleted the 38980-resolve-unclear-organ-names branch August 15, 2025 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: Character/Species Area: Player characters and species features and content. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/S Denotes a PR that changes 10-99 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Human hearts and animal hearts are indistinguishable

4 participants