feat: SimpleRadial menu support for sprite-view and extensibility #39223
+271
−261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riteSpecifier to specify icon to be used
PJBot
added
S: Needs Review
Fildrance
added
P2: Raised
28 tasks
github-actions
bot
added
the
S: Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
S: Merge Conflict
github-actions
bot
added
the
S: Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
chromiumboy
requested changes
Sep 2, 2025
Content.Client/Changeling/Transform/ChangelingTransformBoundUserInterface.cs
Show resolved
Hide resolved
Content.Client/Changeling/Transform/ChangelingTransformBoundUserInterface.cs
Show resolved
Hide resolved
Content.Client/Changeling/Transform/ChangelingTransformBoundUserInterface.cs
Outdated
Show resolved
Hide resolved
Content.Client/Changeling/Transform/ChangelingTransformBoundUserInterface.cs
Outdated
Show resolved
Hide resolved
Content.Client/Changeling/Transform/ChangelingTransformBoundUserInterface.cs
Outdated
Show resolved
Hide resolved
Content.Client/Changeling/Transform/ChangelingTransformBoundUserInterface.cs
Outdated
Show resolved
Hide resolved
Content.Client/UserInterface/Systems/Emotes/EmotesUIController.cs
Outdated
Show resolved
Hide resolved
PJBot
added
S: Awaiting Changes
github-actions
bot
removed
the
S: Merge Conflict
2 tasks
github-actions
bot
added
the
S: Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
chromiumboy
approved these changes
Sep 10, 2025
chromiumboy
removed
the
S: Awaiting Changes
added 2 commits
September 10, 2025 10:12
github-actions
bot
removed
the
S: Merge Conflict
Fildrance
changed the title
sleepyyapril
added a commit
to TheDenSS14/TheDen
that referenced
this pull request
Oct 18, 2025
space-wizards/space-station-14#32653 space-wizards/space-station-14#34639 space-wizards/space-station-14#36486 space-wizards/space-station-14#39223 tested emotes :cl: Fildrance, SaphireLattice, eoineoineoin, sleepyyapril - tweak: The RCD, RPD, card hand selection, modsuit clothing picker, hardlight bow ammo selector, and emotes radial menus have a new look! - fix: The RPD will no longer show RCD popups when selecting things or with charge updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Refactored RadialMenuOption and related SimpleRadialMenu code to accept not just sprite for texture as icon for radial menu, but also entity or entity prototype id for SpriteView. That greatly extends scenarios where SimpleRadialMenu can be used, while leaving convinent API.
GhostRoleRadioBoundUserInterface and related xaml is a victim that got into crossfire.
Changeling menu also was replaced with SimpleRadialMenu and now selected character is highlighted in menu.
Why / Balance
Changeling transformation required SpriteView and did custom view for that, then pAI emotes demanded some, so thats basically planned refactor.
Technical details
RadialMenuEntityIconSpecifier type can be used to further extend controls which can be placed as icons inside radial menu button. Even tho usage of empty abstract class is iffy, current implementation and overloads on RadialMenuEntityIconSpecifier provide best UX for developers i think.
As side effect of refactor - RadialMenuTextureButtonBase no longer is derived from TextureButton so all tree of controls derived from it got renamed too.
Replaced changeling transform menu with SimpleRadial.
Media
lol-emotes.webm
Requirements
Breaking changes
renamings:
RadialMenuOption -> RadialMenuOptionBase (RadialMenuOption.Sprite was replaced by RadialMenuOptionBase.IconSpecifier, use RadialMenuIconSpecifier.With static methods to replace old code)
RadialMenuActionOption -> RadialMenuActionOptionBase
RadialMenuTextureButtonBase -> RadialMenuButtonBase (!IMPORTANT! now is derived from BaseButton so texture template properties are removed, please if you are using any derived class manually - put TextureRect control inside to fix it)
RadialMenuTextureButton -> RadialMenuButton
RadialMenuTextureButtonWithSector -> RadialMenuButtonWithSector
Content.Client/Ghost/GhostRoleRadioMenu.xaml / xaml.cs and Content.Client/Changeling/Transform/ChangelingTransformMenu.xaml / xaml.cs were removed
Changelog