Skip to content

Fix Stamina Animation Applying State Error #39218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix Stamina Animation Applying State Error #39218

wants to merge 1 commit into from

Conversation

@Princess-Cheeseballs
Copy link
Member

@Princess-Cheeseballs Princess-Cheeseballs commented Jul 25, 2025 •
edited
Loading

About the PR

Made the LastJitter vector nullable since when starting the animation, you won't have an initial jitter vector.

Why / Balance

Prevents an error where when checking if you were in the previous quadrant and there wasn't a previous vector (i.e, an entity enters PVS the same tick the animation starts), it would throw an error causing the client to request a full game state.

Technical details

Made a variable nullable and added checks for it.

Media

Requirements

Breaking changes

LastJitter in the StaminaComponent has been made nullable, changed from a Vector2 to a Vector2? You will need to check if the value is null anytime the value is checked.

Changelog

@PJBot PJBot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jul 25, 2025
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 25, 2025
southbridge-fur
southbridge-fur approved these changes Jul 26, 2025
View reviewed changes
Copy link
Contributor

@southbridge-fur southbridge-fur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PJBot PJBot added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Jul 26, 2025
@southbridge-fur southbridge-fur added D2: Medium Difficulty: A good amount of codebase knowledge required. A: General Interactions Area: General in-game interactions that don't relate to another area. T: Bugfix Type: Bugs and/or bugfixes P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jul 26, 2025
@Princess-Cheeseballs
Copy link
Member Author

Closing this PR as it was an incorrect fix for a bug that has now been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@southbridge-fur southbridge-fur southbridge-fur approved these changes

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

Assignees

No one assigned

Labels

A: General Interactions Area: General in-game interactions that don't relate to another area. D2: Medium Difficulty: A good amount of codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/XS Denotes a PR that changes 0-9 lines. T: Bugfix Type: Bugs and/or bugfixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Princess-Cheeseballs @southbridge-fur @PJBot