Fix Whoopie Cushions from lagging the game.

[Princess-Cheeseballs]

About the PR

Why do Whoopie Cushions even use SlipperyComponent? Probably ancient code.
Either way it resulted in client side hitching due to spawning and deleting two status effects in the same tick that did absolutely nothing.

Resolves: #39190

Why / Balance

Better game performance good.

Also we shouldn't ever be applying a status effect for 0 seconds or less.

Technical details

Added a check to prevent a status effect from being spawned and deleted in the same tick (If the time is less than or equal to 0, don't spawn it).

Made some minor optimizations to slippery code as well, although the former fixed solved the issue I'm taking an aggressive approach.

Added two new overloads to Friction Status Effect because the lack of overloads bothered me.

Fixed whoopie cushions applying friction when they shouldn't

Media

Before:

Base.Profile.2025.07.24.-.14.10.30.20.mp4

After:

Base.Profile.2025.07.24.-.14.13.06.21.mp4

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

[sudobeans]

I like it

[Fildrance]

Very good changes imo, dunno how we missed it initially! I moved duration checks inside system, as they all check for invalid usage scenario. i was somewhat hesitant about replacing warning u placed with just plan check and return, but it looks like a questionable guard to me, a little bit ugly. Yet i am unsure about it.
About chaning friction and checking requested friction to not add status effect when not needed - yeah, its fine :3

[slarticodefast]

Can we log an error message or debug assert in case a status effect is applied for 0 seconds?
Or do we already do?

[Princess-Cheeseballs]

Can we log an error message or debug assert in case a status effect is applied for 0 seconds?

Or do we already do?

We don't but it instead exits early. This helps avoid having to copypaste the check everywhere

[Fildrance]

yes i asked to remove that coz it will KINDA incentivize double validation in some cases - like when you do calculated duration and it can be 'negative update' - like, its fine, we just exit early...