Added Kill Tome (Death Note). #39011

xsainteer · 2025-07-16T09:55:31Z

About the PR

Added Death Note and its ability to kill people.

Why / Balance

This would bring more RP situations and chaos to rounds.

Technical details

Added DeathNoteComponent, which grants any paper an ability of Death Note. After a person writes a name in death note, the target is granted a DeathNoteTargetComponent, which has killTime and killDelay variables. DeathNoteSystem's Update method iterates through every DeathNoteTargetComponent entity and checks if killTime has come. That is how that all works.

Media

2025-07-16.15-41-54.mp4

Requirements

[ X] I have read and am following the Pull Request and Changelog Guidelines.
[ X] I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Added new AfterWriteEvent, that is raised on paper (rather than actor) after something was written on it (Needed it to get Paper.Content to get targets' names)

Changelog

…re needed

…htComponent

…tl stuff

github-actions · 2025-07-16T09:56:02Z

RSI Diff Bot; head commit d8aa613 merging into e7b68d9
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Misc/killtome.rsi

State	Old	New	Status
icon			Added

Edit: diff updated after d8aa613

metalgearsloth · 2025-07-16T09:58:44Z

License?

Simyon264 · 2025-07-16T10:01:58Z

Call it unalive tome instead :godo:

lzk228 · 2025-07-16T10:26:44Z

too op imo

EthanQix · 2025-07-16T10:36:11Z

Licensing issues aside, I'm not sure how adding a surefire way to kill someone at any distance, with no way to defend against it nor trace back to the murderer is supposed to "bring more RP situations". This is just a "I WIN" button.

bhenrich · 2025-07-16T11:16:59Z

There are some balancing discussions that need to occur around this, all of which should be kept to the discourse instead of the PR.

ScarKy0 · 2025-07-16T11:22:01Z

Im in full support as long as this is admeme only, it sounds fucking hilarious

xsainteer · 2025-07-16T11:32:30Z

yes, its OP and "I win" button, if somebody has ideas how to balance it please share it with me, its my first PR to ss14 and i just wanted to do something to practice

xsainteer · 2025-07-16T11:37:45Z

License?

I mentioned alexmactep, is it not enough?

CroilBird · 2025-07-16T11:42:27Z

I'd suggest making this make a random crew a sleeper agent, with a kill objective on whoever is written in the death note. It wouldn't be an instant kill/have counterplay and it would be a much more in-universe way of getting killed.

K-Dynamic · 2025-07-16T11:46:31Z

I mentioned alexmactep, is it not enough?

I think they're referring to you having taken an item from the Death Note manga https://en.wikipedia.org/wiki/Death_Note

This would be a great item for a grim reaper or a wizard cosplaying as one btw

Lukasz825700516 · 2025-07-16T15:52:29Z

Resources/Prototypes/Entities/Objects/Misc/deathnote.yml

Is that intended for it to have no contraband label?

Yes, IC characters should not know about Kill Tome, its not an E-Sword, its just a tome (IC)

I guess there should be then non Kill Tome tomes too, so everyone doesn't have to play clueless when they see black book.

players dont have to see other tomes daily in order for them "not to know". I mean i have never seen a tome in my life, but if i see a black one right now, i wont suspect anything

ToastEnjoyer · 2025-07-16T15:57:36Z

When it says "Players can now find the death note" find it where? We should probably limit this use to wizards/admemes otherwise it would be way to powerful.

Entvari · 2025-07-16T16:48:36Z

Thisd be hilarious as admeme if the licensing issue gets sorted, but should ABSOLUTELY NOT BE AVAILABLE TO WIZARD.

purchases deathnote roundstart
"JOHN SECURITY!!! JIMMY ATMOS!!! BILL SCIENCE!!! DEATH TO ALL MY METAGRUDGES!!"

xsainteer · 2025-07-16T17:13:17Z

i renamed it to Kill Tome and removed DeathNoteSpawn event and am leaving you the decision where should Kill Tome be used and how. Up to you to decide

Pumkin69 · 2025-07-18T18:48:03Z

could possibly be a funny wizard item.

Content.Shared/KillTome/KillTomeComponent.cs

Content.Shared/KillTome/KillTomeSystem.cs

Tayrtahn

Seems be be working as intended. I'll leave it up to admins or other maintainers to decide if this is desired content.

ScarKy0 · 2025-07-25T09:22:26Z

Ok so i'm gonna review and approve under the assumption this item will never be made accessible outside of admin intervention.
That being said, review first (I'll probably address myself and merge)

ScarKy0

Heres a review, ill address this one myself (In fact have as I was writing it)

Content.Shared/KillTome/KillTomeComponent.cs

Content.Shared/KillTome/KillTomeTargetComponent.cs

Content.Shared/Paper/PaperSystem.cs

Resources/Prototypes/Entities/Objects/Misc/killtome.yml

Content.Shared/KillTome/KillTomeSystem.cs

Content.Shared/KillTome/KillTomeComponent.cs

ScarKy0

Peak
But please nobody try to make this normally accessible I will cry

Content.Shared/KillTome/KillTomeTargetComponent.cs

TiniestShark · 2025-07-25T22:00:07Z

Well, it's a black book with some white scribbles on it so I'd say it's vague enough to be legally all right. The actual Death Note's pretty simplistic and from my quick searching there's just, so many knock offs. It's fine.

ScarKy0 · 2025-07-25T22:01:26Z

Not gonna post the breaking change since its not a breaking chance, but a technical detail

slarticodefast

The code here needs some cleanup and performance improvements.

slarticodefast · 2025-07-31T17:28:56Z

Content.Shared/KillTome/KillTomeSystem.cs

+            Kill(uid, targetComp);
+
+            _popupSystem.PopupPredicted(Loc.GetString("killtome-death"),
+                Loc.GetString("killtome-death-others", ("target", uid)),


Needs to use Identity.Entity or the popup will reveal disguises.

slarticodefast · 2025-07-31T17:30:55Z

Content.Shared/KillTome/KillTomeSystem.cs

+            // The component doesn't get removed fast enough and the update loop will run through it a few more times.
+            // This check is here to ensure it will not spam popups or kill you several times over.
+            if (targetComp.Dead)
+                continue;


That just sounds like something is mispredicting.
This check shouldn't be needed.

slarticodefast · 2025-07-31T17:31:53Z

Content.Shared/KillTome/KillTomeSystem.cs

+            targetComp.Dead = true;
+
+            RemCompDeferred<KillTomeTargetComponent>(uid);


no need to have this datafield if you are removing the component anyways

slarticodefast · 2025-07-31T17:36:41Z

Content.Shared/KillTome/KillTomeSystem.cs

+
+            ent.Comp.KilledEntities.Add(realUid);
+
+            Dirty(ent);


move outside the loop

slarticodefast · 2025-07-31T17:37:22Z

Content.Shared/KillTome/KillTomeSystem.cs

+
+        // If we have written at least one eligible name, we show the popup (So the player knows death note worked).
+        if (showPopup)
+            _popupSystem.PopupEntity(Loc.GetString("killtome-kill-success"), ent.Owner, args.Actor, PopupType.Large);


doesn't this need prediction?

slarticodefast · 2025-07-31T17:38:02Z

Content.Shared/KillTome/KillTomeSystem.cs

+    // 4. not be already killed by Kill Tome
+
+    // If all these conditions are met, we return true and the entityUid of the person to kill.
+    private bool CheckIfEligible(string name, KillTomeComponent comp, [NotNullWhen(true)] out EntityUid? entityUid)


use Entity<KillTomeComponent>

slarticodefast · 2025-07-31T17:40:00Z

Content.Shared/KillTome/KillTomeSystem.cs

+    private bool CheckIfEligible(string name, KillTomeComponent comp, [NotNullWhen(true)] out EntityUid? entityUid)
+    {
+        if (!TryFindEntityByName(name, out var uid) ||
+            !TryComp<MobStateComponent>(uid, out var mob))


This is a lot of TryComps and name checks every time someone writes in it.
At least the names should be cached somehow.

slarticodefast · 2025-07-31T17:41:17Z

Content.Shared/KillTome/KillTomeSystem.cs

+        if (uid is not { } realUid)
+        {
+            entityUid = null;
+            return false;
+        }


you can just use uid.Value, no need to cast it into a non-nullable and back

slarticodefast · 2025-07-31T17:44:24Z

Content.Shared/KillTome/KillTomeTargetComponent.cs

+    public bool Dead;
+
+    // Disallows cheat clients from seeing who is about to die to the killtome.
+    public override bool SendOnlyToOwner => true;


This also means the death won't be predicted to anyone except the owner.
So in this case it has to be visible to everyone.

This reverts commit d0c104e.

@ScarKy0

This reverts commit d0c104e. Revert suggested due to code issues and passed the voting. @ScarKy0 has interest in fixing it @xsainteer <https://youtu.be/8RmeZKz-i_w?t=2151>

xsainteer added 7 commits July 10, 2025 23:03

added incomplete, but working version of Death Note system

7e23491

Death Note System really works now (not community ready yet though)

66b7c88

death note system works as planned, only cosmetic and logic changes a…

27ac486

…re needed

Now one can specify killDelay + rewrited popup message + ShinigamiSig…

2f3dd4b

…htComponent

Finished all the coding work, need to solve the sprite problem and .f…

62a5828

…tl stuff

Added Death Note

cbfe4d9

delete using directories

1b7d7cf

github-actions bot added the size/M Denotes a PR that changes 100-999 lines. label Jul 16, 2025

xsainteer added 3 commits July 16, 2025 18:10

DeatNote renamed to KillTome, deleted DeathNoteSpawn event

378ee9d

renamed deathnote.rsi to killtome.rsi

85ede1e

changes in .ftl

64cb650

Lukasz825700516 reviewed Jul 16, 2025

View reviewed changes

This comment was marked as abuse.

Sign in to view

Tayrtahn added the A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities label Jul 18, 2025

technical review fix 2

e2e9298

xsainteer force-pushed the death-note branch from 79bfc7e to e2e9298 Compare July 18, 2025 16:17

Restore run file

baef03f

xsainteer requested a review from Tayrtahn July 18, 2025 16:32

Tayrtahn requested changes Jul 21, 2025

View reviewed changes

Content.Shared/KillTome/KillTomeComponent.cs Show resolved Hide resolved

Content.Shared/KillTome/KillTomeSystem.cs Outdated Show resolved Hide resolved

technical review fix 3

a36fe81

xsainteer requested a review from Tayrtahn July 23, 2025 08:41

Tayrtahn approved these changes Jul 23, 2025

View reviewed changes

PJBot added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Jul 23, 2025

Tayrtahn added T: Of Admin Interest Type: Affects administration work a lot, and might require admins to weigh in on and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Jul 23, 2025

ScarKy0 requested changes Jul 25, 2025

View reviewed changes

PJBot added the S: Awaiting Changes Status: Changes are required before another review can happen label Jul 25, 2025

self review

dce9de6

ScarKy0 approved these changes Jul 25, 2025

View reviewed changes

ScarKy0 removed the S: Awaiting Changes Status: Changes are required before another review can happen label Jul 25, 2025

Tayrtahn reviewed Jul 25, 2025

View reviewed changes

Content.Shared/KillTome/KillTomeTargetComponent.cs Show resolved Hide resolved

SendOnlyToOwner

d8aa613

TiniestShark added the S: Art Approval Status: The art (e.g. Spritework) has been approved by an art lead. label Jul 25, 2025

ScarKy0 merged commit d0c104e into space-wizards:master Jul 25, 2025
13 checks passed

xsainteer deleted the death-note branch July 27, 2025 18:59

slarticodefast reviewed Jul 31, 2025

View reviewed changes

VasilisThePikachu added a commit that referenced this pull request Aug 3, 2025

Revert "Added Kill Tome (Death Note). (#39011)"

4a98029

This reverts commit d0c104e.

jorgun mentioned this pull request Aug 18, 2025

The Book of Grudges Goob-Station/Goob-Station#3875

Draft

2 tasks

		targetComp.Dead = true;

		RemCompDeferred<KillTomeTargetComponent>(uid);

Added Kill Tome (Death Note). #39011

Added Kill Tome (Death Note). #39011

Uh oh!

Conversation

xsainteer commented Jul 16, 2025

About the PR

Why / Balance

Technical details

Media

Requirements

Breaking changes

Uh oh!

github-actions bot commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metalgearsloth commented Jul 16, 2025

Uh oh!

Simyon264 commented Jul 16, 2025

Uh oh!

lzk228 commented Jul 16, 2025

Uh oh!

EthanQix commented Jul 16, 2025

Uh oh!

bhenrich commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ScarKy0 commented Jul 16, 2025

Uh oh!

xsainteer commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xsainteer commented Jul 16, 2025

Uh oh!

CroilBird commented Jul 16, 2025

Uh oh!

K-Dynamic commented Jul 16, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ToastEnjoyer commented Jul 16, 2025

Uh oh!

This comment was marked as abuse.

Entvari commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xsainteer commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Pumkin69 commented Jul 18, 2025

Uh oh!

Uh oh!

Uh oh!

Tayrtahn left a comment

Choose a reason for hiding this comment

Uh oh!

ScarKy0 commented Jul 25, 2025

Uh oh!

ScarKy0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ScarKy0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TiniestShark commented Jul 25, 2025

github-actions bot commented Jul 16, 2025 •

edited

Loading

bhenrich commented Jul 16, 2025 •

edited

Loading

xsainteer commented Jul 16, 2025 •

edited

Loading

Entvari commented Jul 16, 2025 •

edited

Loading

xsainteer commented Jul 16, 2025 •

edited

Loading