Skip to content

Rename cryogenic sleep unit into hypersleep unit #38923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Rename cryogenic sleep unit into hypersleep unit #38923

wants to merge 23 commits into from

Conversation

@kosticia
Copy link
Contributor

@kosticia kosticia commented Jul 11, 2025 •
edited
Loading

About the PR

This pr renames cryogenic sleep unit into hypersleep unit. Also, it renames cryogenics access into hypersleep access.

Why / Balance

Resolves #25406.
Hypersleep is the most liked suggestion in #25406. Also, “hyper” prefix used only in hyperlathes that makes it less confusing variant.

Technical details

Every Cryogenic mention has been changed to Hypersleep

Breaking changes

Here all migrated entities:

CryogenicSleepUnitSpawnerLateJoin: HyperSleepUnitSpawnerLateJoin
CryogenicSleepUnitSpawner: HyperSleepUnitSpawner
CryogenicSleepUnit: HyperSleepUnitSpawner
SignCryo: SignHyperSleep
SignDirectionalCryo: SignDirectionalHyperSleep
DefaultStationBeaconCryosleep: DefaultStationBeaconHypersleep
HolopadGeneralCryosleep: HolopadGeneralHypersleep

Other changes are just locales/sprites/partical yml.

Requirements

Changelog
🆑

  • tweak: Cryogenic sleep units are now called hypersleep units, to avoid confusion.

@kosticia kosticia requested a review from crazybrain23 as a code owner July 11, 2025 09:30
@PJBot PJBot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jul 11, 2025
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-99 lines. label Jul 11, 2025
TheShuEd
TheShuEd previously requested changes Jul 11, 2025
View reviewed changes
Copy link
Member

@TheShuEd TheShuEd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also need rename prototypes & update migrations

@PJBot PJBot added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Jul 11, 2025
@kosticia
Copy link
Contributor Author

also need rename prototypes & update migrations

Access prototype too?

@PJBot PJBot added the Changes: Sprites Changes: Might require knowledge of spriting or visual design. label Jul 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025 •
edited
Loading

RSI Diff Bot; head commit 8b59726 merging into 42c519b
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Wallmounts/signs.rsi

State Old New Status
cryo Removed
direction_cryo Removed
direction_sleep Added
sleep Added

Edit: diff updated after 8b59726

@Simyon264
Copy link
Member

Renaming the prototype is a huge breaking change. I wouldn't rename the prototype, just change the entity name

@TheShuEd TheShuEd dismissed their stale review July 11, 2025 11:37

meh, ok

kosticia added 5 commits July 11, 2025 15:44
@kosticia
Revert "fix last proto"
945ea77 
This reverts commit 4cdcfa6.
@kosticia
Revert "aw"
2fe62d2 
This reverts commit 81f875f.
@kosticia
IT
17c37da
@kosticia
Revert "dev it"
7030ac2 
This reverts commit 35672de.
@kosticia
Revert "and other"
4ed3899 
This reverts commit 3723bc6.
EmoGarbage404
EmoGarbage404 requested changes Jul 11, 2025
View reviewed changes
Copy link
Contributor

@EmoGarbage404 EmoGarbage404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The larger cryo sign needs to be updated. You can find the sign font in the template subdirectory inside of the textures folder.

@EmoGarbage404 EmoGarbage404 added the S: Art Approval Status: The art (e.g. Spritework) has been approved by an art lead. label Jul 11, 2025
@Cojoke-dot
Copy link
Contributor

Uhhh, 2 things:

  1. Cryo Station beacon, I don't think I saw that name changed in the pr
  2. When you select your starting location in the spawn menu, either from cryosleep or shuttle, idk if you got that but want to make sure.

@K-Dynamic
Copy link
Contributor

Renaming the prototype is a huge breaking change. I wouldn't rename the prototype, just change the entity name

I think it might be needed since the point is to avoid confusion with cryopods for both players and backend coding

@kosticia
Copy link
Contributor Author

I think it might be needed since the point is to avoid confusion with cryopods for both players and backend coding

Forks are really love to add everlasting blueshilds, brigmedics and other amazing roles with cryogenics access. This change will be really painful.

@deltanedas
Copy link
Contributor

its just a yml linter error, not hard to fix

@kosticia
Copy link
Contributor Author

its just a yml linter error, not hard to fix

looks like you have never seen REAL russian forks and its developers

@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jul 26, 2025
@github-actions github-actions bot added S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted and removed S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Jul 27, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ToastEnjoyer ToastEnjoyer added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Aug 6, 2025
@github-actions github-actions bot added S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted and removed S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Aug 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Aug 11, 2025
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Aug 31, 2025
@github-actions github-actions bot added S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted and removed S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Sep 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmoGarbage404 EmoGarbage404 EmoGarbage404 requested changes

@TheShuEd TheShuEd TheShuEd left review comments

@crazybrain23 crazybrain23 Awaiting requested review from crazybrain23 crazybrain23 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

A: General Interactions Area: General in-game interactions that don't relate to another area. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Sprites Changes: Might require knowledge of spriting or visual design. P3: Standard Priority: Default priority for repository items. S: Art Approval Status: The art (e.g. Spritework) has been approved by an art lead. S: Awaiting Changes Status: Changes are required before another review can happen S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted size/S Denotes a PR that changes 10-99 lines. T: New Feature Type: New feature or content, or extending existing content

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Cryo" is confusing and should be renamed

9 participants

@kosticia @Simyon264 @K-Dynamic @Cojoke-dot @deltanedas @TheShuEd @EmoGarbage404 @PJBot @ToastEnjoyer