Make station AI unable to see through unpowered cameras

[NoElkaTheGod]

"It's a good point that removing vision on power loss is inconsistent with the current behavior of cameras.". said chromiumboy.
"Well then let's fuck up the cameras too!", I thought, and made this PR.

About the PR

Surveilance cameras and holopads now require power to allow the station AI to see through them.
To prevent some stupid situations, APCs are now always visible to the AI (StationAiVisionwith range: 0), so it doesn't have to call engineers when there is a disabled APC.

Why / Balance

1. It makes sense. Camera monitor cannot see through unpowered cameras, why can AI do that?
2. Provides some much needed counterplay to the AI. Curently you can only disable a camera by directly interacting with it (breaking or snipping wires), which is not an option if you want to not be seen.

Technical details

YAML ops.

Media

Power on:

Power off:

Requirements

• I have read and am following the Pull Request and Changelog Guidelines.
• I have added media to this PR or it does not require an ingame showcase.

Changelog
🆑

• tweak: Station AI can no longer see through unpowered cameras and holopads.
• tweak: APCs are now always visible to the station AI.

[perryprog]

Definitely a needed fix but I admittedly did enjoy being only able to silently watch as AI during a power outage.

[slarticodefast]

We had a similar PR before, which was denied because we would like something like this change to the AI overlay first
#32438
That way the AI player can still somewhat interact in the case of a power outage rather than just staring at static.

[EthanQix]

Could we make it so unpowered cameras switch to an "emergency power" mode, with drastically reduced view range ? That way the AI wouldn't be completely blind in the event of a blackout, but antags could still snake through its blind spots.

[perryprog]

I do wonder if a stealth antag item that overlaid the border of the AI range with a line/other indicator (especially coupled with the above idea) would be feasible.

[Velken]

Could we make it so unpowered cameras switch to an "emergency power" mode, with drastically reduced view range ? That way the AI wouldn't be completely blind in the event of a blackout, but antags could still snake through its blind spots.

Maybe have it only see the tile the camera itself is on while unpowered (like how it can still see the APC despite not having vision)

[deltanedas]

if theres no power doorknob cant open those doors anyway, a crowbar would

[Simyon264]

I think a good middle ground would be cameras having an internal battery that lasts them a short 2 minutes or something because the AI being able to see via cameras that aren't powered is not an intuitive gameplay mechanic.

[VerinSenpai]

What do apc channels look like?

[LankLTE]

AI gameplay about to get even more miserable let's go.
Seriously, this is probably a good idea, but in the state AI is in currently I don't know if also just completely blinding them randomly is a worthwhile addition

[TheFlyingSentry]

I'd much rather see cameras turn red while AI's looking through them than have them be disabled during power outages if you want to add counterplay or at least some way to tell that you're about to get caught.
Even then if cameras do get affected by power i'd rather it reduce their vision instead of outright removing it so the AI player has something to look at.

AI already doesn't have much to do and removing their ability to see because the power goes down doesn't help that fact.
Theres a bit of a concern when power is VERY flickery it could possibly induce epilepsy though i'm not sure how probable that it could happen (and frankly if it's getting that bad it'd affect everyone and not just the AI player :b)

[Simyon264]

https://forum.spacestation14.com/t/make-station-ai-unable-to-see-through-unpowered-cameras/22335

[Simyon264]

Please do not discuss the gameplay changes of this PR in this thread any further. Use the Forum Topic instead.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[VerinSenpai]

Something got changed to match a change that you made and when you merged master it got resolved.

[FungiFellow]

Probably best to reduce vision range instead of removing it altogether.

[Fildrance]

By the power of smol maintainer meeting it was decided that to have AI have almost absolute zero vision on station upon power outage OR when cameras were disabled - is really not nice from gameplay standpoint. Thus FOR NOW we are closing this one until we have #40088 completed