Skip to content

Conversation

kosticia
Copy link
Contributor

@kosticia kosticia commented Jul 8, 2025

About the PR

This pr moves all of MimePowersSystem into shared

Why / Balance

Closes #38851
Prediction is good

Requirements

Breaking changes

MimePowersComponent and MimePowersSystem have been moved to the Content.Shared.Abilities.Mime namespace.

@PJBot PJBot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jul 8, 2025
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-99 lines. label Jul 8, 2025
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The invisible wall action needs the popups predicted.
Same for the spawn of the invisible wall.
And dirty the component when you change its datafields.
Also you can set SendOnlyToOwner in the component to true because other clients don't need the component. Not really that critical if cheat clients can see it, but it's also a performance improvement.

@PJBot PJBot added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Jul 8, 2025
@kosticia
Copy link
Contributor Author

kosticia commented Jul 9, 2025

Same for the spawn of the invisible wall.

Wait, predicted spawning is really so necessary for invisible wall? Because it's pretty invisible and feels only on collide and the moving is pretty unpredicted.

@slarticodefast
Copy link
Member

I guess it's not completely needed, but doesn't hurt either. It makes sure you can't put any items into that location if you are lagging.

@github-actions github-actions bot added size/M Denotes a PR that changes 100-999 lines. and removed size/S Denotes a PR that changes 10-99 lines. labels Jul 28, 2025
@slarticodefast slarticodefast added T: Refactor Type: Refactor of notable amount of codebase A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Awaiting Changes Status: Changes are required before another review can happen labels Jul 28, 2025
Copy link
Member

@slarticodefast slarticodefast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some more cleanup changes.
Thank you for your contribution!

@PJBot PJBot added the S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. label Jul 28, 2025
@slarticodefast slarticodefast merged commit 4c24db9 into space-wizards:master Jul 28, 2025
13 of 15 checks passed
@kosticia
Copy link
Contributor Author

I thought that we don't change "namespaces()" to "namespaces;" to get less merge conflicts in the forks.

@slarticodefast
Copy link
Member

We were moving the file anyways, so I would say it's fine in this case.

@kosticia kosticia deleted the predictmiming branch August 11, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: General Interactions Area: General in-game interactions that don't relate to another area. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/M Denotes a PR that changes 100-999 lines. T: Refactor Type: Refactor of notable amount of codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MimePowersSystem needs prediction

3 participants