-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Predict mimepowers #38859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Predict mimepowers #38859
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The invisible wall action needs the popups predicted.
Same for the spawn of the invisible wall.
And dirty the component when you change its datafields.
Also you can set SendOnlyToOwner
in the component to true
because other clients don't need the component. Not really that critical if cheat clients can see it, but it's also a performance improvement.
Wait, predicted spawning is really so necessary for invisible wall? Because it's pretty invisible and feels only on collide and the moving is pretty unpredicted. |
I guess it's not completely needed, but doesn't hurt either. It makes sure you can't put any items into that location if you are lagging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed some more cleanup changes.
Thank you for your contribution!
I thought that we don't change "namespaces()" to "namespaces;" to get less merge conflicts in the forks. |
We were moving the file anyways, so I would say it's fine in this case. |
About the PR
This pr moves all of
MimePowersSystem
into sharedWhy / Balance
Closes #38851
Prediction is good
Requirements
Breaking changes
MimePowersComponent
andMimePowersSystem
have been moved to theContent.Shared.Abilities.Mime
namespace.