Skip to content

fix ItemSlotsSystem debug assert #38655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2025
Merged

fix ItemSlotsSystem debug assert #38655

merged 1 commit into from
Jun 29, 2025

Conversation

@slarticodefast
Copy link
Member

@slarticodefast slarticodefast commented Jun 29, 2025 •
edited
Loading

About the PR

Another bugfix for #38438
To reproduce the assert on master spawn a sabre sheath [Filled], put it on your belt and use smart equip twice.

Why / Balance

bugfix

Technical details

It was passing in the wrong uid, which did not belong to the HandsComponent.

Requirements

Breaking changes

none

Changelog
🆑

  • fix: Fixed smart equip not being able to insert items into item slots (for example for the sabre sheath).

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/XS Denotes a PR that changes 0-9 lines. labels Jun 29, 2025
@slarticodefast slarticodefast added P1: High Priority: Higher priority than other items, but isn't an emergency. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: General Interactions Area: General in-game interactions that don't relate to another area. T: Bugfix Type: Bugs and/or bugfixes and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jun 29, 2025
@EmoGarbage404 EmoGarbage404 merged commit 4bd4372 into space-wizards:master Jun 29, 2025
16 checks passed
@slarticodefast slarticodefast deleted the fix-hand-refactor-sabre branch June 29, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmoGarbage404 EmoGarbage404 Awaiting requested review from EmoGarbage404

Assignees

No one assigned

Labels

A: General Interactions Area: General in-game interactions that don't relate to another area. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P1: High Priority: Higher priority than other items, but isn't an emergency. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/XS Denotes a PR that changes 0-9 lines. T: Bugfix Type: Bugs and/or bugfixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@slarticodefast @EmoGarbage404