-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Delete label workflows in favor for SS14.Labeller #38653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
my hero |
|
DNM while SS14.Labeller isn't setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to just disable these workflows instead? So downstreams can use them.
|
If we just disable the checks it (probably, not sure) show up under every PR as a "skipped" check which is annoying |
This has been shown to be incorrect. |
About the PR
Deletes our current labeling workflows in favor of https://github.com/space-wizards/SS14.Labeller
Why / Balance
Currently, our label workflows are kind of bad. They race condition each other and the review label workflow does not work at all.
As a solution I have made SS14.Labeller, a NativeAOT ASP NET Core application that labels PRs and issues using a webhook and GitHub PAT Token. Because it uses NativeAOT compilation, the application only uses around 20mb of RAM.
Requirements
Breaking changes
Label workflows have been removed in favor of https://github.com/space-wizards/SS14.Labeller