Skip to content

Minor escape menu update #38650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2025
Merged

Minor escape menu update #38650

merged 2 commits into from
Jul 5, 2025

Conversation

@beck-thompson
Copy link
Member

Why / Balance

It looks better! Not 100% sure on the red quit button

Media

image

Requirements

Changelog

🆑

  • tweak: The escape menu ui has been updated slightly.

@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: UI Changes: Might require knowledge of UI design or code. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/XS Denotes a PR that changes 0-9 lines. labels Jun 29, 2025
@beck-thompson beck-thompson added P3: Standard Priority: Default priority for repository items. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. T: UI / UX Improvement Type: UI and player facing interactive graphical interfaces S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. labels Jun 29, 2025
@Kowlin
Copy link
Contributor

Kowlin commented Jun 29, 2025

I think the red quit button is fitting. Its a button that expresses "danger". Something that impacts more when just a normal button.

@Errant-4
Copy link
Member

Errant-4 commented Jun 29, 2025 •
edited
Loading

Can you please also split off Call Vote into its own group, since it does not really belong with those other 3 buttons conceptually (but could be accompanied by the Bug Report/Feedback feature's button, whenever that happens)

@lzk228
Copy link
Contributor

lzk228 commented Jun 29, 2025

maybe it's not within the scope of this pr, but i'd like the quit button to require two clicks
like it's done with choosing type of borg chassis

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines. label Jun 29, 2025
@beck-thompson
Copy link
Member Author

maybe it's not within the scope of this pr, but i'd like the quit button to require two clicks
like it's done with choosing type of borg chassis

It wasn't super clear cut what people thought of it when I brought it up so I didn't want to add it to this pr specifically! Not a bad idea though

Fildrance
Fildrance approved these changes Jul 5, 2025
View reviewed changes
Copy link
Contributor

@Fildrance Fildrance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, why not

@PJBot PJBot added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Jul 5, 2025
@Fildrance Fildrance merged commit 14668f2 into space-wizards:master Jul 5, 2025
10 checks passed
Admiral-Obvious-001 pushed a commit to Admiral-Obvious-001/space-station-14 that referenced this pull request Jul 12, 2025
@beck-thompson @Admiral-Obvious-001
Minor escape menu UX improvements (space-wizards#38650)
53c0927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fildrance Fildrance Fildrance approved these changes

Assignees

No one assigned

Labels

Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: UI Changes: Might require knowledge of UI design or code. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Awaiting Changes Status: Changes are required before another review can happen size/XS Denotes a PR that changes 0-9 lines. T: UI / UX Improvement Type: UI and player facing interactive graphical interfaces

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@beck-thompson @Kowlin @Errant-4 @lzk228 @Fildrance @PJBot