Localize makesentient command. Move makesentient method to mind system. #38565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/M
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
WHY GOD WHY!!! |
github-actions
bot
removed
the
S: Merge Conflict
Fildrance
requested changes
Jun 28, 2025
|
Fildrance?!? How can this be??? |
|
Good call on the EnsureComp shortcut. I was a touch confused by what you meant but I got it. |
Fildrance
added
T: Refactor
Content.Server/Mind/MindSystem.cs
Outdated
| using Robust.Shared.Player; | ||
| using Robust.Shared.Utility; | ||
| using System.Diagnostics.CodeAnalysis; | ||
| using Content.Shared.Emoting; |
| [Dependency] private readonly FollowerSystem _followerSystem = default!; | ||
| [Dependency] private readonly TransformSystem _transform = default!; | ||
| [Dependency] private readonly SharedMindSystem _mindSystem = default!; | ||
| [Dependency] private readonly MindSystem _mindSystem = default!; |
There was a problem hiding this comment.
keep the Shared system and move the command to shared instead
|
You got it boss man |
slarticodefast
approved these changes
Jul 23, 2025
PJBot
removed
the
S: Needs Review
FairlySadPanda
pushed a commit
to FairlySadPanda/honk-station-15
that referenced
this pull request
Jul 25, 2025
…m. (space-wizards#38565) * praying pjb doesn't smite me for this 🙏 * requested changes * Update makesentient-command.ftl * verin commith and verin taketh away
Princess-Cheeseballs
pushed a commit
to Princess-Cheeseballs/space-station-14
that referenced
this pull request
Aug 1, 2025
…m. (space-wizards#38565) * praying pjb doesn't smite me for this 🙏 * requested changes * Update makesentient-command.ftl * verin commith and verin taketh away
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Why / Balance
I have now made it my mission to move these reusable methods to systems 😠
With that said, I moved MakeSentient to server side MindSystem and updated references accordingly (including cleanup up using statements as I went). I felt like the MindSystem was a good place for this but I can of course make a new system for it if that is so desired.
Otherwise performed localization and cleanup of the makesentient command. I moved the EntityExists check to the line with TryGetEntity because that was as it was in the electrocute command and I felt this made sense. Do comment on it if that is wrong.
Requirements
Breaking changes
MakeSentient method has been moved from MakeSentientCommand.cs to Content.Shared\Mind\SharedMindSystem.cs and the EntityManager variable was removed. Calls to this method will need to be updated.