Skip to content

Conversation

Nox38
Copy link
Contributor

@Nox38 Nox38 commented Jun 15, 2025

About the PR

Rebuilt the security department of Packed to include genpop, a security/secure armory setup, and a very nice warden room.

Why / Balance

Genpop has been overdue for a while.

Technical details

Media

Uploading Packed-0.png…

Requirements

Breaking changes

Changelog
🆑 Nox38, ArtisticRoomba

  • add: On Packed, added Genpop and revamped security.
  • tweak: On Packed, revamped the north maints area above security.
  • tweak: On Packed, revamped Science.

Signed-off-by: Nox38 <[email protected]>
@ss14-map-server
Copy link

ss14-map-server bot commented Jun 15, 2025

This PR contains new or changed maps:

Packed

image

08/17/25 18:47

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. Changes: Map Changes: Might require knowledge of mapping. size/XL Denotes a PR that changes 5000+ lines. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jun 15, 2025
@Nox38 Nox38 marked this pull request as ready for review June 18, 2025 21:35
@Djungelskog2
Copy link

Djungelskog2 commented Jun 23, 2025

just to point out that the turret in the armory will have a hard time targeting anyone in the actual armory section of the armory, combined with the fact that the guns face space with a single maints hall (with an airlock) between it. That combined with the fact that the HOS room could also be very easily bombed into at the same time, aswell as the armory having zero windows to prevent any observation or use of lazers and that the armory (the REAL armory) is far away from most idle-sec areas (brig/genpop/warden panopticon) All of it just combines to make a far less secure armory than most other maps typically would have.

Most of these things wouldnt normally be that bad on their own and make up the weaknesses of different maps armoury's but they very rarely have them all at once, except the turret thing, the turret should basically always be able to shoot people in the armoury if not dealt with.

Misc notes,the Prisoner EVA's look really out of place as the first thing you see as soon as you enter sec throught the main entrance, and the mop while wielded does the same damage as a baseball bat (15 blunt) and only takes 5 more hits to break a reinforced window, so do with that what you will considering there is one in genpop (You could probably replace it with towels)

@Nox38
Copy link
Contributor Author

Nox38 commented Jun 24, 2025

Thanks for all the feedback, ill do my best to get it in. Since bolts can’t travel over safes its difficult to make it compact and defended, might need to redo armory layout idk.

@spanky-spanky
Copy link
Member

image
Unless I'm missing it, there should be a control panel at the front of the AI core entrance.
I agree with prisoner eva/armory comments above, assuming this is the latest render. I might take a stab at the armory after merge if you aren't sure how to approach.

@spanky-spanky spanky-spanky added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. D3: Low Difficulty: Some codebase knowledge required. A: Mapping Area: Maps, or tools used for mapping and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jun 30, 2025
Signed-off-by: Nox38 <[email protected]>
@Nox38
Copy link
Contributor Author

Nox38 commented Jul 1, 2025

Armory, AI core, and rest of security updated!
okay, so Davyei deleted the captain spawn but everything else should be ready

Copy link
Member

@spanky-spanky spanky-spanky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has my approval pending the captain spawn fix, @ArtisticRoomba have a glance and see if your changes are addressed to your liking before merge

@PJBot PJBot added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Awaiting Changes Status: Changes are required before another review can happen labels Jul 1, 2025
Copy link
Member

@ArtisticRoomba ArtisticRoomba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Captain doesn't have a spawnpoint

@ArtisticRoomba
Copy link
Member

Also, I would just combine the Captain's room into one room with a cot instead of attempting to cram everything into two rooms, it looks much worse. Either that or you can reclaim the space the captain used to have from maints.

@ArtisticRoomba
Copy link
Member

ArtisticRoomba commented Jul 2, 2025

And remove the shotgun cabinet from the warden's bedroom please. I would also fill gaps in maints with carts, tanks, limited vends, etc. as it's pretty open with nothing sitting in it right now. See Box, Bagel, Fland, etc.

Copy link
Member

@ArtisticRoomba ArtisticRoomba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

not sure why this is happening as it appears powered but it needs to be fixed

  • do not route LV wire under walls in xenoarch ruins, arti chamber, or paramed (unsure if you did paramed or not)
  • do not route MV wire behind APCs as it makes it hard to follow for any engi wanting to trace a wire
  • there are uncolored pipes

@Nox38
Copy link
Contributor Author

Nox38 commented Aug 1, 2025

  • do not route LV wire under walls in xenoarch ruins, arti chamber, or paramed (unsure if you did paramed or not)
  • do not route MV wire behind APCs as it makes it hard to follow for any engi wanting to trace a wire
  • there are uncolored pipes

Most of packed's APCs run MV cable from the opposite side of the wall, ill get started redoing the cabling I guess...

Signed-off-by: Nox38 <[email protected]>
@PJBot PJBot removed the size/XL Denotes a PR that changes 5000+ lines. label Aug 1, 2025
@ArtisticRoomba
Copy link
Member

Oh, you don't have to do them all, just the ones you modified. I'm not scope creeping your PR, that's unreasonable for me to ask.

@PJBot PJBot added the size/XL Denotes a PR that changes 5000+ lines. label Aug 2, 2025
@PJBot PJBot removed the size/XL Denotes a PR that changes 5000+ lines. label Aug 2, 2025
@Nox38
Copy link
Contributor Author

Nox38 commented Aug 2, 2025

After 7 or 8 attempts at replacing the air alarm and making it start powered, I gave up and just connected it to the adjoining room's alarm. Everything should be ready to go now, @ArtisticRoomba .

@Nox38 Nox38 requested a review from ArtisticRoomba August 3, 2025 18:53
@PJBot PJBot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Aug 3, 2025
Copy link
Member

@ArtisticRoomba ArtisticRoomba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, so science got completely creeped into this with no mention of this in the PR, I ask that you please specify what you're changing in advance, just a general overview. I understand that you want this PR in because packed has lacked Genpop for forever but including another department rework is just not a good idea if you want this to go by quickly. Spanky also told you that you shouldn't have made science changes in this PR a month back.

Security is fine and Science is fine, the thing that's off about it is the decaling. The corners overlapping with the regular department trim don't make it look good - it would be better to do something similar like what you did in Security (which has good decaling). Be sure to make it colored as well.

Sorry for dragging you through all of this but these are quality issues that I want to keep up with.

@PJBot PJBot added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Aug 4, 2025
@Nox38
Copy link
Contributor Author

Nox38 commented Aug 7, 2025

Yeah, so science got completely creeped into this with no mention of this in the PR, I ask that you please specify what you're changing in advance, just a general overview. I understand that you want this PR in because packed has lacked Genpop for forever but including another department rework is just not a good idea if you want this to go by quickly. Spanky also told you that you shouldn't have made science changes in this PR a month back.

Security is fine and Science is fine, the thing that's off about it is the decaling. The corners overlapping with the regular department trim don't make it look good - it would be better to do something similar like what you did in Security (which has good decaling). Be sure to make it colored as well.

Sorry for dragging you through all of this but these are quality issues that I want to keep up with.

Im sorry, especially with two people and me constantly getting annoyed by tiny issues its really easy to feature creep it. At this point sunk cost fallacy has sunk in, so we will get sci decalling up to spec.

@Nox38 Nox38 changed the title Packed security overhaul Packed Station - North East Overhaul Aug 7, 2025
@PJBot PJBot added the size/XL Denotes a PR that changes 5000+ lines. label Aug 8, 2025
@Nox38 Nox38 requested a review from ArtisticRoomba August 8, 2025 20:36
@PJBot PJBot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Aug 8, 2025
Copy link
Member

@ArtisticRoomba ArtisticRoomba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am formally begging you to recognize the scope of your changes. i have reviewed this pull request 9 times over the span of 2-3 months which is extremely unreasonable, and its mostly because you unnecessarily change (x) which was fine or introduce some new (y) area in scope-creep. you also often dont listen to my requested changes. the map turned out well, and i thank you for working on this, but please, never do this again.

@ArtisticRoomba ArtisticRoomba merged commit 8e34228 into space-wizards:master Aug 17, 2025
10 checks passed
@ArtisticRoomba ArtisticRoomba deleted the Packed-Armory-Overhaul branch August 17, 2025 19:00
@Nox38
Copy link
Contributor Author

Nox38 commented Aug 17, 2025

i am formally begging you to recognize the scope of your changes. i have reviewed this pull request 9 times over the span of 2-3 months which is extremely unreasonable, and its mostly because you unnecessarily change (x) which was fine or introduce some new (y) area in scope-creep. you also often dont listen to my requested changes. the map turned out well, and i thank you for working on this, but please, never do this again.

I'm so sorry about all this and how many times its needed to be reviewed because of my scope-creeping, I promise it won't happen again. Thank you for putting up with my bullshit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: Mapping Area: Maps, or tools used for mapping Changes: Map Changes: Might require knowledge of mapping. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. size/XL Denotes a PR that changes 5000+ lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants