-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Feature/door remote radial #36378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/door remote radial #36378
Conversation
…on. Radial menu position setting into was moved to OverrideArrange to not being called on every frame
…olor pallet for radial menu button
… menu buttons with sectors, RadialContainer Radius renamed and now actually changed control radius.
…converted to and from sRGB in property getter-setters
… outside menu closes menu always
… 32px sprites using scale in radial menu
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
I fixed the merge conflicts and pushed some small cleanup.
|
|
Changed to use new Palette, looks the same in game, changed it for ling too - less references of obsolete, less warnings! now about status control. I would like to keep it - it seems like we want more of those. But amount of boilerplate boggles me! I will look at it. |
|
ItemStatusControl mispredicts awkwardly, no idea why. Will have to sleep with that thought. |
Probably because it uses a frameupdate loop, which does randomly show whatever prediction is currently calculating. |
|
Well the FrameUpdate loop part was kinda obvious, but the problem with StatusControls is that they are all kinda doing updates in that loop - none of them are doing proper event-based stuff. This is kinda disgusting, but at the same time it means we dont get proper infrastructure to plug events in, unless we will commit several war crimes, like storing nullable control object inside system. Other controls avoid mispredict by exposing extra fields in component, that dictate state specifically for StatusControl. Thats an option, i guess, but... hell thats ugly... |
|
Fixed mispredicts, but codewise its a small bloat of boilerplate, annoying AH. StatusControl stuff looks like it needs a refactor for a way to plug events in, but this PR is obviously not good place to start that. |
…p after handle method
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With only the auto handle state subscription update the status control won't show when picking it up, only when you first change the setting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, this is so much more convenient to use!
0a0806a
About the PR
door remotes now use radial menu to chenge modes. Previously they used cycling over modes using 'use' keybind.
Why / Balance
fixing #31977
abusing new easy to create radials. neat stuff!
Technical details
Moved DoorRemote code from server to shared, mostly untouched, changed calls to doors system to use prediction and passed actual user uid (was using remote device as user).
Media
door-remote-radial-colored.mp4
Requirements
Breaking changes
Changelog
🆑 Fildrance