Skip to content

Some wallmount .yml cleanup #34329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jul 26, 2025
Merged

Some wallmount .yml cleanup #34329

merged 21 commits into from
Jul 26, 2025

Conversation

@kosticia
Copy link
Contributor

@kosticia kosticia commented Jan 9, 2025

About the PR

Wallmount staff become a little bit more standardized.

Why / Balance

Now we have pretty much issues with a wallmounts, like a weird hitboxes of telescreen or screens that can't be deconstructed. It should be fixed, and the first step to create really good wallmounts is a standardization of .yml entity files

Technical details

Only .yml changes, added base wallmount entities and parents for other wallmounts

Requirements

@github-actions github-actions bot added Changes: No C# Changes: Requires no C# knowledge to review or fix this item. S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines. labels Jan 9, 2025
@IamVelcroboy
Copy link
Contributor

Hey, beat me to it! I was about to do this in the next day or two. Good on you though. One less thing on my list! 😎

@IamVelcroboy
Copy link
Contributor

If you could add wallmounted rechargers and the mini nanomed. Those 2 items are pretty broken at the moment.

@kosticia
Copy link
Contributor Author

kosticia commented Jan 9, 2025

If you could add wallmounted rechargers and the mini nanomed. Those 2 items are pretty broken at the moment.

Sure, forgot about those one

@lzk228 lzk228 added P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. A: Core Tech Area: Underlying core tech for the game and the Github repository. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 9, 2025
@github-actions github-actions bot added size/L Denotes a PR that changes 1000-4999 lines. and removed size/M Denotes a PR that changes 100-999 lines. labels Jan 10, 2025
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 31, 2025
@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jan 31, 2025
@github-actions github-actions bot removed the size/L Denotes a PR that changes 1000-4999 lines. label Apr 19, 2025
@github-actions github-actions bot added S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted and removed S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Apr 19, 2025
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@kosticia
Copy link
Contributor Author

Goddamn

@github-actions github-actions bot added S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted and removed S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted labels Apr 25, 2025
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the S: Merge Conflict Status: Needs to resolve merge conflicts before it can be accepted label Jul 26, 2025
@kosticia
Copy link
Contributor Author

9 january...

southbridge-fur
southbridge-fur approved these changes Jul 26, 2025
View reviewed changes
Copy link
Contributor

@southbridge-fur southbridge-fur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PJBot PJBot added S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Jul 26, 2025
@kosticia
Copy link
Contributor Author

Yay!

@southbridge-fur southbridge-fur merged commit 21d4736 into space-wizards:master Jul 26, 2025
11 checks passed
@kosticia kosticia deleted the wallmount branch July 26, 2025 19:47
@scrivoy scrivoy mentioned this pull request Jul 26, 2025
Open
@kosticia
Copy link
Contributor Author

kosticia commented Aug 5, 2025 •
edited
Loading

I accidentally deleted
- type: Appearance
From the screen proto during cleaning redundant components and now its dead.
I'm stupid. Sorry.

@perryprog perryprog mentioned this pull request Aug 5, 2025
Closed
2 tasks
@southbridge-fur southbridge-fur mentioned this pull request Aug 6, 2025
Merged
2 tasks
@perryprog perryprog mentioned this pull request Aug 8, 2025
Closed
@kosticia kosticia mentioned this pull request Aug 8, 2025
Merged
2 tasks
@lzk228 lzk228 mentioned this pull request Aug 31, 2025
Merged
This was referenced Sep 21, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@southbridge-fur southbridge-fur southbridge-fur approved these changes

@Emisse Emisse Emisse approved these changes

Assignees

No one assigned

Labels

A: Core Tech Area: Underlying core tech for the game and the Github repository. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P3: Standard Priority: Default priority for repository items. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. size/M Denotes a PR that changes 100-999 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kosticia @IamVelcroboy @southbridge-fur @Emisse @PJBot @lzk228