Model static fires equalizing with the local atmosphere

Content.Server/Atmos/Components/FlammableComponent.cs

@@ -1,4 +1,5 @@
 using Content.Shared.Alert;
+using Content.Shared.Atmos;
 using Content.Shared.Damage;
 using Robust.Shared.Physics.Collision.Shapes;
 using Robust.Shared.Prototypes;
@@ -11,40 +12,40 @@ public sealed partial class FlammableComponent : Component
         [DataField]
         public bool Resisting;
 
-        [ViewVariables(VVAccess.ReadWrite)]
+        /// <summary>
+        /// Does this entity require oxygen to burn
+        /// </summary>
+        [DataField]
+        public bool RequireOxygen = true;
+
         [DataField]
         public bool OnFire;
 
-        [ViewVariables(VVAccess.ReadWrite)]
         [DataField]
         public float FireStacks;
 
-        [ViewVariables(VVAccess.ReadWrite)]
         [DataField]
         public float MaximumFireStacks = 10f;
 
-        [ViewVariables(VVAccess.ReadWrite)]
         [DataField]
         public float MinimumFireStacks = -10f;
 
-        [ViewVariables(VVAccess.ReadWrite)]
         [DataField]
         public string FlammableFixtureID = "flammable";
 
-        [ViewVariables(VVAccess.ReadWrite)]
         [DataField]
         public float MinIgnitionTemperature = 373.15f;
 
-        [ViewVariables(VVAccess.ReadWrite)]
+        [DataField]
+        public float PeakFlameTemperature = 1500.00f; // vaguely how hot an incenerator gets.
+
         [DataField]
         public bool FireSpread { get; private set; } = false;
 
-        [ViewVariables(VVAccess.ReadWrite)]
         [DataField]
         public bool CanResistFire { get; private set; } = false;
 
         [DataField(required: true)]
-        [ViewVariables(VVAccess.ReadWrite)]
         public DamageSpecifier Damage = new(); // Empty by default, we don't want any funny NREs.
 
         /// <summary>
@@ -56,31 +57,34 @@ public sealed partial class FlammableComponent : Component
         /// <summary>
         ///     Should the component be set on fire by interactions with isHot entities
         /// </summary>
-        [ViewVariables(VVAccess.ReadWrite)]
         [DataField]
         public bool AlwaysCombustible = false;
 
         /// <summary>
         ///     Can the component anyhow lose its FireStacks?
         /// </summary>
-        [ViewVariables(VVAccess.ReadWrite)]
         [DataField]
         public bool CanExtinguish = true;
 
         /// <summary>
         ///     How many firestacks should be applied to component when being set on fire?
         /// </summary>
-        [ViewVariables(VVAccess.ReadWrite)]
         [DataField]
         public float FirestacksOnIgnite = 2.0f;
 
         /// <summary>
         /// Determines how quickly the object will fade out. With positive values, the object will flare up instead of going out.
         /// </summary>
-        [DataField, ViewVariables(VVAccess.ReadWrite)]
+        [DataField]
         public float FirestackFade = -0.1f;
 
         [DataField]
         public ProtoId<AlertPrototype> FireAlert = "Fire";
+
+        /// <summary>
+        /// A maximum quantity of gas to be added to the atmosphere every update while on fire.
+        /// </summary>
+        [DataField]
+        public GasMixture? EmissiveGasMix;
     }
 }

Content.Server/Atmos/EntitySystems/FlammableSystem.cs

@@ -28,6 +28,7 @@
 using Robust.Shared.Physics.Events;
 using Robust.Shared.Physics.Systems;
 using Robust.Shared.Random;
+using Content.Shared.Atmos.Piping.Binary.Components;
 
 namespace Content.Server.Atmos.EntitySystems
 {
@@ -413,7 +414,6 @@ public override void Update(float frameTime)
 
             _timer -= UpdateTime;
 
-            // TODO: This needs cleanup to take off the crust from TemperatureComponent and shit.
             var query = EntityQueryEnumerator<FlammableComponent, TransformComponent>();
             while (query.MoveNext(out var uid, out var flammable, out _))
             {
@@ -433,20 +433,40 @@ public override void Update(float frameTime)
 
                 if (flammable.FireStacks > 0)
                 {
-                    var air = _atmosphereSystem.GetContainingMixture(uid);
+                    var air = _atmosphereSystem.GetContainingMixture(uid, false, true);
 
-                    // If we're in an oxygenless environment, put the fire out.
-                    if (air == null || air.GetMoles(Gas.Oxygen) < 1f)
+                    if (flammable.RequireOxygen)
                     {
-                        Extinguish(uid, flammable);
-                        continue;
+                        // If we're in an oxygenless environment, put the fire out.
+                        if (air == null || air.GetMoles(Gas.Oxygen) < 1f)
+                        {
+                            Extinguish(uid, flammable);
+                            continue;
+                        }
                     }
 
                     var source = EnsureComp<IgnitionSourceComponent>(uid);
                     _ignitionSourceSystem.SetIgnited((uid, source));
 
                     if (TryComp(uid, out TemperatureComponent? temp))
-                        _temperatureSystem.ChangeHeat(uid, 12500 * flammable.FireStacks, false, temp);
+                    {
+                        // get hot
+                        var maxDeltaT = flammable.PeakFlameTemperature - temp.CurrentTemperature;
+                        if (maxDeltaT > 0) // we dont want to burn and get colder.
+                        {
+                            var tempBump = MathF.Sqrt(maxDeltaT) * flammable.FireStacks * 25; //monotonic function, slows as it reaches maxT
+                            _temperatureSystem.ChangeHeat(uid, tempBump, false, temp);
+                        } 
+
+                        // release gas
+                        if (air != null && flammable.EmissiveGasMix != null)
+                        {
+                            flammable.EmissiveGasMix.Temperature = temp.CurrentTemperature;
+                            var releasingGas = new GasMixture(flammable.EmissiveGasMix.Volume);
+                            _atmosphereSystem.Merge(releasingGas, flammable.EmissiveGasMix); // generate gas for the entity's entire burning lifespan, but we use ReleaseGasTo to handle temperature/pressure for us since those will change for other reasons.
+                            _atmosphereSystem.ReleaseGasTo(releasingGas, air, releasingGas.Pressure); // doing it this way means that we dont need to track the entity damage values or know its destructible or mobstate thresholds.
+                        }                                                                    // the downside, and a possible later rework, is that you ""lose"" some gas if the candle is burning in an atmosphere where it can't emit due to pressure.
+                    }                                                                        // the yml is also slightly cumbersome, because we now specify a "maximum release mix per update (second)" instead of a total gasmix in the entity.
 
                     var ev = new GetFireProtectionEvent();
                     // let the thing on fire handle it

Resources/Prototypes/Catalog/Cargo/cargo_atmospherics.yml

@@ -111,3 +111,13 @@
 #  cost: 15500
 #  category: cargoproduct-category-name-atmospherics
 #  group: market
+
+- type: cargoProduct
+  id: AtmosphericsCandles
+  icon:
+    sprite: Objects/Misc/candles.rsi
+    state: candle-big
+  product: CrateCandlesAir
+  cost: 2500 # its ~ 32000 mols of Air mix potential. Cheap though because no cannister, and youve got to cool it and collect it to use it.
+  category: cargoproduct-category-name-atmospherics
+  group: market

Resources/Prototypes/Catalog/Fills/Boxes/engineering.yml

@@ -0,0 +1,11 @@
+- type: entity
+  name: air candle box
+  parent: BoxCandle
+  id: BoxCandleAir
+  components:
+  - type: StorageFill
+    contents:
+      - id: CandleGasNitrogen
+        amount: 9
+      - id: CandleGasOxygen
+        amount: 3

Resources/Prototypes/Catalog/Fills/Crates/engineering.yml

@@ -215,3 +215,15 @@
   - type: StorageFill
     contents:
       - id: SpaceHeaterFlatpack
+
+- type: entity
+  id: CrateCandlesAir
+  parent: CrateEngineeringSecure
+  name: air candle crate
+  description: A crate containing 2 boxes of air gas candles.
+  components:
+  - type: StorageFill
+    contents:
+    - id: BoxCandleAir
+      amount: 2
+    - id: BoxFlare

Resources/Prototypes/Entities/Objects/Misc/candles.yml

@@ -32,7 +32,7 @@
       canResistFire: false
       alwaysCombustible: true
       canExtinguish: true
-      firestacksOnIgnite: 3.0
+      firestacksOnIgnite: 3.3
       firestackFade: -0.01
       damage:
         types: