Skip to content

Update pull request guidelines to address PR size #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slarticodefast wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −0
Open

Update pull request guidelines to address PR size #634

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0593d76
Update pull request guidelines to address PR size
slarticodefast Apr 18, 2026
bc3634b
typo
slarticodefast Apr 18, 2026
bf8c244
rewrite
slarticodefast Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/en/general-development/codebase-info/pull-request-guidelines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ Your pull request may be reverted or closed for any reason.

- Large new features and comprehensive reworks to existing large features (ie antags or anything that could be considered a subdepartment unto itself), should first be [proposed and accepted in abstract](../feature-proposals.md) before you start working on actually implementing it.

- Don't make make giant PRs containing several thousand lines of code. Instead split them up into smaller parts, especially for major new features like antagonists or game modes. Implementing them one step at a time makes them much easier to review. On the other hand if your PR is too large it is very likely that it will not receive any reviews because reviewing it all at once is simply not feasible or would take multiple days of maintainer time. If you want to work on a larger project and are unsure where to start, best to talk to a maintainer beforehand.

- Read the [Freezes and Restrictions issue](https://github.com/space-wizards/space-station-14/issues/8524) and make sure your PR does not interfere with anything or requires special requirements.

- If you are fixing a bug that is present on the live servers, or addressing an urgent balance issue on the live servers, consider if your change should be a hotfix.
Expand Down
Loading