Update pull request guidelines to address PR size#634
Open
slarticodefast wants to merge 3 commits intomasterfrom
Open
Update pull request guidelines to address PR size#634slarticodefast wants to merge 3 commits intomasterfrom
slarticodefast wants to merge 3 commits intomasterfrom
Conversation
Simyon264
approved these changes
Apr 18, 2026
keronshb
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We sometimes get giant PRs that have thousands of lines of code, for example for new game modes and antags. As a result they often gather dust and are eventually closed because reviewing them all at once is simply unfeasible.
A few examples:
space-wizards/space-station-14#42776
space-wizards/space-station-14#30094
space-wizards/space-station-14#24013
space-wizards/space-station-14#40545
I added a small section in the PR guidelines warning contributors not to do this, so that they don't waste their time.