Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(audit-service): make exceljs dependency optional #2097

Merged
merged 7 commits into from
May 31, 2024
Merged

Conversation

Surbhi-sharma1
Copy link
Contributor

@Surbhi-sharma1 Surbhi-sharma1 commented May 20, 2024

make exceljs dependency optional

GH-2088

Description

make eceljs dependency optional.

Fixes #2088

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@Surbhi-sharma1 Surbhi-sharma1 marked this pull request as draft May 20, 2024 04:05
@Surbhi-sharma1 Surbhi-sharma1 marked this pull request as ready for review May 29, 2024 12:39
Copy link

sonarcloud bot commented May 31, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yeshamavani yeshamavani merged commit f1cdbf4 into master May 31, 2024
5 checks passed
@yeshamavani yeshamavani deleted the GH-2088 branch May 31, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit log throws unexpected error on start of the service
2 participants