fix(audit-service): fix test case

fix test case GH-2088
sourcefuse · May 29, 2024 · f332d77 · f332d77
1 parent 17663d6
commit f332d77
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 18 deletions.
diff --git a/services/audit-service/README.md b/services/audit-service/README.md
@@ -32,6 +32,7 @@ Additionally, the audit-service goes beyond basic functionality by offering an a
 
 ```bash
 npm i @sourceloop/audit-service
+
 ```
 
 ## Getting Started
@@ -127,7 +128,6 @@ export class AuditDbDataSource
 
 The migrations required for this service are processed during the installation automatically if you set the `AUDIT_MIGRATION` or `SOURCELOOP_MIGRATION` env variable. The migrations use [`db-migrate`](https://www.npmjs.com/package/db-migrate) with [`db-migrate-pg`](https://www.npmjs.com/package/db-migrate-pg) driver for migrations, so you will have to install these packages to use auto-migration. Please note that if you are using some pre-existing migrations or databases, they may be affected. In such a scenario, it is advised that you copy the migration files in your project root, using the `AUDIT_MIGRATION_COPY` or `SOURCELOOP_MIGRATION_COPY` env variables. You can customize or cherry-pick the migrations in the copied files according to your specific requirements and then apply them to the DB.
 
-
 Additionally, there is now an option to choose between SQL migration or PostgreSQL migration.
 NOTE : for [`@sourceloop/cli`](https://www.npmjs.com/package/@sourceloop/cli?activeTab=readme) users, this choice can be specified during the scaffolding process by selecting the "type of datasource" option.
 

diff --git a/services/audit-service/src/__tests__/helpers/db.helper.ts b/services/audit-service/src/__tests__/helpers/db.helper.ts
@@ -64,20 +64,17 @@ export async function getTestDBRepositories(app: DummyAuditServiceApplication) {
 
 export function getTestAuditController(app: DummyAuditServiceApplication) {
   let auditLogExportParam: AnyObject[];
-  const auditLogExport: AuditLogExportFn = (data: AnyObject[]) => {
-    auditLogExportParam = data;
-    return Promise.resolve();
-  };
-
   function getAuditLogExportParameter() {
     return auditLogExportParam;
   }
-
   const exportToCsvService: ExportToCsvFn = () =>
     Promise.resolve('demoResponse');
   const {jobProcessingService} = getTestJobProcessingService(app);
   const columnBuilderProvider = new ColumnBuilderProvider();
-
+  const auditLogExport: AuditLogExportFn = (data: AnyObject[]) => {
+    auditLogExportParam = data;
+    return Promise.resolve();
+  };
   const auditLogController = new AuditController(
     auditLogRepository,
     jobRepository,

diff --git a/services/audit-service/src/controllers/audit.controller.ts b/services/audit-service/src/controllers/audit.controller.ts
@@ -398,10 +398,6 @@ export class AuditController {
         return {message: 'No data to be exported'};
       }
       const customColumnData = await this.columnBuilderService(result);
-      // const app = this.ctx.getSync(
-      //   AuditLogExportServiceBindings.EXPORT_AUDIT_LOGS,
-      // );
-      // await app(customColumnData);
       await this.auditLogExportService(customColumnData);
       return {message: 'Audit logs exported successfully.'};
     }

diff --git a/services/audit-service/src/index.ts b/services/audit-service/src/index.ts
@@ -6,7 +6,6 @@ export * from './component';
 export * from './enums';
 export * from './keys';
 export * from './models';
-//  export * from './providers';
 export * from './repositories';
 export * from './services';
 export * from './types';
diff --git a/services/audit-service/src/services/job-processing.service.ts b/services/audit-service/src/services/job-processing.service.ts
@@ -31,7 +31,6 @@ export class JobProcessingService {
     public querySelectedFiles: QuerySelectedFilesFn,
     @inject(AuditLogExportServiceBindings.EXPORT_AUDIT_LOGS)
     public auditLogExportService: AuditLogExportFn,
-    // @inject.context() private readonly ctx: Context,
     @inject(ColumnBuilderServiceBindings.COLUMN_BUILDER)
     public columnBuilder: ColumnBuilderFn,
     @repository(MappingLogRepository)
@@ -96,10 +95,6 @@ export class JobProcessingService {
 
       if (job.operation === OperationKey.EXPORT) {
         const customColumnData = await this.columnBuilder(finalData);
-        // const app = this.ctx.getSync(
-        //   AuditLogExportServiceBindings.EXPORT_AUDIT_LOGS,
-        // );
-        // await app(customColumnData);
         await this.auditLogExportService(customColumnData);
       }
       job.status = FileStatusKey.COMPLETED;