feat: validate space strategies #513
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR introduces a new validation mechanism for space strategies by fetching a list of approved strategies from an external API.
- Importing fetchWithKeepAlive and a new SCORE_API_URL from environment variables
- Adding a try-catch block in the verify function to validate strategy names and deprecation status
- Rejecting the process if any strategy is invalid or deprecated
Reviewed Changes
| File | Description |
|---|---|
| src/writer/settings.ts | Validates strategies by calling an external API to ensure strategy validity and status |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
wa0x6e
force-pushed
the
feat-validate-space-strategies
branch
from
0188a18 to
5d8276d
Compare
wa0x6e
force-pushed
the
feat-validate-space-strategies
branch
from
5d8276d to
fac6311
Compare
ChaituVR
requested changes
Mar 12, 2025
| @@ -80,6 +81,26 @@ export async function verify(body): Promise<any> { | |||
| return Promise.reject(`max number of strategies is ${strategiesLimit}`); | |||
| } | |||
|
|
|||
| try { | |||
| const strategiesList = await (await fetchWithKeepAlive(`${scoreAPIUrl}/api/strategies`)).json(); | |||
There was a problem hiding this comment.
Maybe we should call it every 5 mins instead of calling it everytime, but can make things look complicated 🙈
| @@ -80,6 +81,26 @@ export async function verify(body): Promise<any> { | |||
| return Promise.reject(`max number of strategies is ${strategiesLimit}`); | |||
| } | |||
|
|
|||
| try { | |||
There was a problem hiding this comment.
Maybe we should move this check and strategies limit check to a new function similar to validateSpaceSettings
ChaituVR
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward https://github.com/snapshot-labs/workflow/issues/227
This PR adds validation to the space top level strategies.
It will ensure that:
Test
multichainstrategy