feat: validate space strategies

Author: wa0x6e

src/writer/settings.ts

@@ -5,10 +5,11 @@ import { addOrUpdateSpace, getSpace } from '../helpers/actions';
 import log from '../helpers/log';
 import db from '../helpers/mysql';
 import { getLimit, getSpaceType } from '../helpers/options';
-import { clearStampCache, DEFAULT_NETWORK, jsonParse } from '../helpers/utils';
+import { clearStampCache, DEFAULT_NETWORK, fetchWithKeepAlive, jsonParse } from '../helpers/utils';
 
 const SNAPSHOT_ENV = process.env.NETWORK || 'testnet';
 const broviderUrl = process.env.BROVIDER_URL || 'https://rpc.snapshot.org';
+const scoreAPIUrl = process.env.SCORE_API_URL || 'https://score.snapshot.org';
 
 export async function validateSpaceSettings(originalSpace: any) {
   const spaceType = originalSpace.turbo ? 'turbo' : 'default';
@@ -80,6 +81,26 @@ export async function verify(body): Promise<any> {
     return Promise.reject(`max number of strategies is ${strategiesLimit}`);
   }
 
+  try {
+    const strategiesList = await (await fetchWithKeepAlive(`${scoreAPIUrl}/api/strategies`)).json();
+
+    msg.payload.strategies
+      .map(strategy => strategy.name)
+      .forEach(strategyName => {
+        const strategy = strategiesList[strategyName];
+
+        if (!strategy) {
+          return Promise.reject(`strategy "${strategyName}" is not a valid strategy`);
+        }
+
+        if (strategy.disabled) {
+          return Promise.reject(`strategy "${strategyName}" has been deprecated`);
+        }
+      });
+  } catch (e) {
+    return Promise.reject('failed to validate strategies');
+  }
+
   const controller = await snapshot.utils.getSpaceController(msg.space, DEFAULT_NETWORK, {
     broviderUrl
   });

test/unit/writer/settings.test.ts

@@ -13,7 +13,10 @@ function randomStrategies(count = 1) {
   return Array(count)
     .fill(0)
     .map(() => ({
-      name: `strategy-${Math.floor(Math.random() * 1000)}`
+      name: 'whitelist',
+      params: {
+        addresses: [`0x${Math.floor(Math.random() * 1000)}`]
+      }
     }));
 }
 
@@ -134,7 +137,7 @@ describe('writer/settings', () => {
       it.todo('rejects if the submitter does not have permission to change admin');
       const maxStrategiesForNormalSpace = LIMITS['space.default.strategies_limit'];
       const maxStrategiesForTurboSpace = LIMITS['space.turbo.strategies_limit'];
-      it(`rejects if passing more than ${maxStrategiesForNormalSpace} strategies for normal space`, async () => {
+      it.only(`rejects if passing more than ${maxStrategiesForNormalSpace} strategies for normal space`, async () => {
         return expect(
           verify(
             editedInput({