Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --long-timeouts-multiplier CLI flag #7047

Merged

Conversation

macladson
Copy link
Member

Proposed Changes

Adds the --long-timeouts-multiplier flag.
Allows granular control for VC timeouts which has proved useful in Holesky.

Additional Info

Defaults to 1 and for clarity requires use of the --use-long-timeouts flag in order to function.
A multiplier of 0 is technically possible which I believe will disable timeouts.

@macladson macladson added ready-for-review The code is ready for review v7.0.0 New release c. Q1 2025 labels Feb 26, 2025
@macladson macladson mentioned this pull request Feb 26, 2025
13 tasks
@macladson macladson added v7.0.0-beta.clean Clean release post Holesky rescue and removed v7.0.0 New release c. Q1 2025 labels Feb 26, 2025
Co-authored-by: Lion - dapplion <[email protected]>
@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Feb 27, 2025
@macladson macladson added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Feb 27, 2025
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Mar 5, 2025
mergify bot added a commit that referenced this pull request Mar 5, 2025
@mergify mergify bot merged commit 29a295a into sigp:release-v7.0.0 Mar 5, 2025
32 checks passed
@macladson macladson deleted the long-timeouts-multiplier-flag branch March 5, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to merge. v7.0.0-beta.clean Clean release post Holesky rescue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants