-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --long-timeouts-multiplier
CLI flag
#7047
Merged
mergify
merged 5 commits into
sigp:release-v7.0.0
from
macladson:long-timeouts-multiplier-flag
Mar 5, 2025
Merged
Add --long-timeouts-multiplier
CLI flag
#7047
mergify
merged 5 commits into
sigp:release-v7.0.0
from
macladson:long-timeouts-multiplier-flag
Mar 5, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
reviewed
Feb 26, 2025
dapplion
reviewed
Feb 26, 2025
Co-authored-by: Lion - dapplion <[email protected]>
michaelsproul
requested changes
Feb 27, 2025
michaelsproul
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adds the
--long-timeouts-multiplier
flag.Allows granular control for VC timeouts which has proved useful in Holesky.
Additional Info
Defaults to
1
and for clarity requires use of the--use-long-timeouts
flag in order to function.A multiplier of
0
is technically possible which I believe will disable timeouts.