-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v7.0.0-beta.2 (Holesky Rescue) #7041
Open
paulhauner
wants to merge
30
commits into
holesky-rescue-target-branch
Choose a base branch
from
holesky-rescue
base: holesky-rescue-target-branch
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lid finalized epochs in sync.
…lid finalized epochs in sync.
|
This was referenced Feb 26, 2025
Closed
mergify bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
Cleaned up and isolated version of the `--disable-attesting` flag for the VC, from the `holesky-rescue` branch: - #7041 I figured we don't need the `--disable-attesting` flag on the BN for now, and it was a much more invasive impl.
* Optimise status processing * Fix lint --------- Co-authored-by: Michael Sproul <[email protected]>
…ByRange` requests (#7058) * Load block roots from fork choice where possible to avoid loading state from disk when serving block by range requests. * Check if the start slot is newer than finalization (`start_slot >= finalized_slot`), and use fork choice in that case.
* Load block roots from fork choice where possible to avoid loading state from disk when serving block by range requests. * Check if the start slot is newer than finalization (`start_slot >= finalized_slot`), and use fork choice in that case. * force finalization endpoint * cleanup * Remove ds store * Don't import blocks that conflict with the split * Disconnect and ban peer if we get blocks conflicting manual checkpoint * immediately commit state to cold db * revert * Fix descent from split check * Add safety check to checkpoint when doing manual finalization. --------- Co-authored-by: Jimmy Chen <[email protected]> Co-authored-by: Michael Sproul <[email protected]> Co-authored-by: Pawan Dhananjay <[email protected]>
* SSZ bump in a single clean commit * Do the actual intra-rebases * Update milhouse
#7066) * handle bbr across finalized slot gracefully * sort deps * Michael's off-by-one corrections --------- Co-authored-by: Michael Sproul <[email protected]>
Trying to get CI running/passing on this so we have a bit more confidence in the release. |
* add an update_cache flag to get_state to have more granular control over when we write to the cache * State cache tweaks - add state-cache-headroom flag to control pruning - prune old epoch boundary states ahead of mid-epoch states - never prune head block's state - avoid caching ancestor states unless they are on an epoch boundary --------- Co-authored-by: Michael Sproul <[email protected]>
* Add a trusted_peers endpoint * Maintain trusted peers in heartbeat
* Add CI fixes. * Remove log and update cli docs. * Build caches after loading state from disk. * Revert payload invalidation API - wasn't working because of the justification being permanently updated.
* manual compaction endpoint * linting --------- Co-authored-by: Michael Sproul <[email protected]>
DanielJP-Crypto
approved these changes
Mar 6, 2025
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Related to #7040
Proposed Changes
Various hacks and tweaks to ensure LH syncs a valid Holesky chain.
Most notably, we explicitly reject the invalid payload that was justified (
0x2db899881ed8546476d0b92c6aa9110bea9a4cd0dbeb5519eb0ea69575f1f359
).Additional Info