Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v7.0.0-beta.2 (Holesky Rescue) #7041

Open
wants to merge 30 commits into
base: holesky-rescue-target-branch
Choose a base branch
from

Conversation

paulhauner
Copy link
Member

@paulhauner paulhauner commented Feb 26, 2025

Issue Addressed

Related to #7040

Proposed Changes

Various hacks and tweaks to ensure LH syncs a valid Holesky chain.

Most notably, we explicitly reject the invalid payload that was justified (0x2db899881ed8546476d0b92c6aa9110bea9a4cd0dbeb5519eb0ea69575f1f359).

Additional Info

  • Use this branch if you are running a node on Holesky

Copy link

mergify bot commented Feb 26, 2025

⚠️ The sha of the head commit of this PR conflicts with #7035. Mergify cannot evaluate rules on this PR. ⚠️

mergify bot pushed a commit that referenced this pull request Feb 26, 2025
Cleaned up and isolated version of the `--disable-attesting` flag for the VC, from the `holesky-rescue` branch:

- #7041

I figured we don't need the `--disable-attesting` flag on the BN for now, and it was a much more invasive impl.
jimmygchen and others added 5 commits February 27, 2025 21:23
* Optimise status processing

* Fix lint

---------

Co-authored-by: Michael Sproul <[email protected]>
…ByRange` requests (#7058)

* Load block roots from fork choice where possible to avoid loading state from disk when serving block by range requests.

* Check if the start slot is newer than finalization (`start_slot >= finalized_slot`), and use fork choice in that case.
* Load block roots from fork choice where possible to avoid loading state from disk when serving block by range requests.

* Check if the start slot is newer than finalization (`start_slot >= finalized_slot`), and use fork choice in that case.

* force finalization endpoint

* cleanup

* Remove ds store

* Don't import blocks that conflict with the split

* Disconnect and ban peer if we get blocks conflicting manual checkpoint

* immediately commit state to cold db

* revert

* Fix descent from split check

* Add safety check to checkpoint when doing manual finalization.

---------

Co-authored-by: Jimmy Chen <[email protected]>
Co-authored-by: Michael Sproul <[email protected]>
Co-authored-by: Pawan Dhananjay <[email protected]>
* SSZ bump in a single clean commit

* Do the actual intra-rebases

* Update milhouse
michaelsproul and others added 2 commits March 4, 2025 09:17
#7066)

* handle bbr across finalized slot gracefully

* sort deps

* Michael's off-by-one corrections

---------

Co-authored-by: Michael Sproul <[email protected]>
@michaelsproul michaelsproul changed the base branch from unstable to release-v7.0.0 March 3, 2025 23:01
@michaelsproul michaelsproul changed the base branch from release-v7.0.0 to holesky-rescue-target-branch March 3, 2025 23:02
@michaelsproul michaelsproul marked this pull request as ready for review March 3, 2025 23:03
@michaelsproul michaelsproul requested a review from jxs as a code owner March 3, 2025 23:03
@michaelsproul
Copy link
Member

Trying to get CI running/passing on this so we have a bit more confidence in the release.

eserilev and others added 2 commits March 4, 2025 11:15
* add an update_cache flag to get_state to have more granular control over when we write to the cache

* State cache tweaks

- add state-cache-headroom flag to control pruning
- prune old epoch boundary states ahead of mid-epoch states
- never prune head block's state
- avoid caching ancestor states unless they are on an epoch boundary

---------

Co-authored-by: Michael Sproul <[email protected]>
pawanjay176 and others added 2 commits March 4, 2025 14:34
* Add a trusted_peers endpoint

* Maintain trusted peers in heartbeat
* Add CI fixes.

* Remove log and update cli docs.

* Build caches after loading state from disk.

* Revert payload invalidation API - wasn't working because of the justification being permanently updated.
@michaelsproul michaelsproul changed the title v7.0.0-beta.1 (Holesky Rescue) v7.0.0-beta.2 (Holesky Rescue) Mar 4, 2025
eserilev and others added 2 commits March 4, 2025 15:44
* manual compaction endpoint

* linting

---------

Co-authored-by: Michael Sproul <[email protected]>
@dapplion dapplion mentioned this pull request Mar 7, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants