Allow to set GitHub API version #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new set_api_version method the GitHub class that accepts an API version string as defined in [1]. The version is added to the session headers. Sessions headers remain unchanged if no version string was given. Addresses #1121. [1]: https://docs.github.com/en/rest/overview/api-versions?apiVersion=2022-11-28
sigmavirus24
reviewed
Mar 2, 2023
|
@sigmavirus24 Should the |
|
This replaces the setter method with a named parameter of __init__.
|
@sigmavirus24 I removed |
sigmavirus24
approved these changes
Mar 2, 2023
|
@sigmavirus24 Are there any plans for a new release? I'm just asking because the last tag is from March last year. |
|
I don't have the time right now but maybe @staticdev does? |
|
@anz-ableton I will find some time soon. |
|
@sigmavirus24 can you add user |
|
Resent the invite @staticdev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
set_api_versionmethod theGitHubclass that accepts an API version string as defined here. The version is added to the session headers. Sessions headers remain unchanged if no version string was given.Addresses #1121.