Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for X-GitHub-Api-Version HTTP header #1121

Open
cknowles-moz opened this issue Nov 29, 2022 · 3 comments
Open

Support for X-GitHub-Api-Version HTTP header #1121

cknowles-moz opened this issue Nov 29, 2022 · 3 comments

Comments

@cknowles-moz
Copy link

GitHub recently announced the REST API versioning [1], and that they plan breaking changes to the API. In order to avoid this, they created the X-GitHub-Api-Version header to allow us to fix ourselves in time. Would be good to have this supported in this library.

[1] https://github.blog/2022-11-28-to-infinity-and-beyond-enabling-the-future-of-githubs-rest-api-with-api-versioning/
@sigmavirus24
Copy link
Owner

Yup, it sure would be good. Happy to review a pull request that adds this

@alfawal
Copy link

alfawal commented Mar 2, 2023

@anz-ableton
Can you please open a PR in this parent repository?

@anz-ableton anz-ableton mentioned this issue Mar 2, 2023
Merged
@anz-ableton
Copy link
Contributor

@alfawal 👍 There's the PR: #1132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sigmavirus24 @cknowles-moz @alfawal @anz-ableton