Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added package.json without any dependencies #81

Merged
merged 2 commits into from
Oct 6, 2022
Merged

added package.json without any dependencies #81

merged 2 commits into from
Oct 6, 2022

Conversation

sayamalvi
Copy link
Contributor

I added package.json but it don't have any dependecies. If you have node_modules folder in your local repository do push it on remote, I will try to recover the dependencies then you can put it in .gitignore again

Copy link
Owner

@sharanya-mitra sharanya-mitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change the license. 💟

package.json Outdated
"url": "git+https://github.com/sayamalvi/Todolist.git"
},
"author": "",
"license": "ISC",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, you write ISC license but our project is under an MIT license.

@sharanya-mitra sharanya-mitra added enhancement New feature or request hacktoberfest hacktoberfest-accepted your PR is successfully merged under hacktoberfest guidelines. labels Oct 6, 2022
@sayamalvi
Copy link
Contributor Author

Changed the license. Do have a look !

@sharanya-mitra sharanya-mitra merged commit 1a275aa into sharanya-mitra:master Oct 6, 2022
@sharanya-mitra sharanya-mitra linked an issue Oct 6, 2022 that may be closed by this pull request
@sayamalvi
Copy link
Contributor Author

Hey @Rick-mad-lab take a look at package.json again. You should change the repository url to your own repo, it currently shows url of my forked repo. Also change the homepage url too.

@sayamalvi sayamalvi deleted the package.json branch October 6, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest hacktoberfest-accepted your PR is successfully merged under hacktoberfest guidelines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package.json missing !
2 participants