Upgrade concurrently package and move to devDependencies #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `concurrently` dependencies is only used for linting/formatting tasks in package-scripts.yml. Moving it to devDependencies removes an unnecessary runtime dependencies for end users.
Judahmeek
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As an end user of react_on_rails we ran some checks on external dependencies and noticed the outdated
concurrentlydependency. After investigating I noticed theconcurrentlydependency is only used for linting/formatting tasks in package-scripts.yml. Moving it to devDependencies removes an unnecessary dependency for end users.This change is