Skip to content

Commit

Permalink
Upgrade concurrently package and move to devDependencies (#1571)
Browse files Browse the repository at this point in the history
* Upgrade concurrently npm package and move to devDependencies

The `concurrently` dependencies is only used for linting/formatting
tasks in package-scripts.yml. Moving it to devDependencies removes
an unnecessary runtime dependencies for end users.

* drop node 12 from package tests

---------

Co-authored-by: Judah Meek <[email protected]>
  • Loading branch information
menno and Judahmeek authored Aug 1, 2023
1 parent de657f3 commit fea6536
Show file tree
Hide file tree
Showing 3 changed files with 80 additions and 126 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/package-js-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
build:
strategy:
matrix:
node: [12, 14]
node: [14]
runs-on: ubuntu-22.04
steps:
- uses: actions/checkout@v2
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"@typescript-eslint/parser": "^4.33.0",
"babelify": "^10.0.0",
"blue-tape": "^1.0.0",
"concurrently": "^8.2.0",
"create-react-class": "^15.7.0",
"eslint": "^7.32.0",
"eslint-config-prettier": "^7.0.0",
Expand All @@ -46,8 +47,7 @@
"typescript": "^4.9.4"
},
"dependencies": {
"@babel/runtime-corejs3": "^7.12.5",
"concurrently": "^5.1.0"
"@babel/runtime-corejs3": "^7.12.5"
},
"peerDependencies": {
"js-yaml": ">= 3.0.0",
Expand Down
Loading

0 comments on commit fea6536

Please sign in to comment.