Skip to content

STRATCONN-6533: remove alphabetical field order flag and related logic #3702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhandage wants to merge 2 commits into
base: main
Choose a base branch
from
Open

STRATCONN-6533: remove alphabetical field order flag and related logic #3702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c527ab7
refactor: remove alphabetical field order flag and related logic
abhandage Mar 30, 2026
3cf316c
fix: address review comments - remove stale metric and update comments
Copilot Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
215 changes: 2 additions & 213 deletions packages/destination-actions/src/destinations/liveramp-audiences/__tests__/liveramp.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,8 @@
import nock from 'nock'
import { createTestIntegration, PayloadValidationError, SegmentEvent, StatsContext } from '@segment/actions-core'
import { createTestIntegration, PayloadValidationError, SegmentEvent } from '@segment/actions-core'
import Destination from '../index'
import fs from 'fs'
import {
LIVERAMP_ALPHABETICAL_FIELD_ORDER_FLAG_NAME,
LIVERAMP_ENABLE_COMPRESSION_FLAG_NAME,
LIVERAMP_MIN_RECORD_COUNT
} from '../properties'
import { LIVERAMP_ENABLE_COMPRESSION_FLAG_NAME, LIVERAMP_MIN_RECORD_COUNT } from '../properties'

const testDestination = createTestIntegration(Destination)

Expand Down Expand Up @@ -220,109 +216,6 @@ describe('Liveramp Audiences', () => {
}
})

it('should track incoming header order metric when statsContext is provided', async () => {
const mockStatsClient = {
histogram: jest.fn(),
incr: jest.fn(),
observe: jest.fn(),
_name: '',
_tags: [],
set: jest.fn()
}
const statsContext: StatsContext = { statsClient: mockStatsClient as any, tags: ['test-tag'] }
await testDestination.executeBatch('audienceEnteredS3', {
events: mockedEvents,
mapping: {
s3_aws_access_key: 's3_aws_access_key',
s3_aws_secret_key: 's3_aws_secret_key',
s3_aws_bucket_name: 's3-aws-bucket-name',
s3_aws_region: 's3_aws_region',
audience_key: 'audience_key',
delimiter: ',',
filename: 'filename.csv',
enable_batching: true,
identifier_data: {
email: { '@path': '$.properties.email' },
first_name: { '@path': '$.properties.first_name' }
}
},
subscriptionMetadata: {
destinationConfigId: 'test-destination-config-id',
actionConfigId: 'test-action-config-id',
sourceId: 'test-source-id',
actionId: 'test-action-id'
},
settings: {
__segment_internal_engage_force_full_sync: true,
__segment_internal_engage_batch_sync: true
},
statsContext
})

expect(mockStatsClient.incr).toHaveBeenCalledWith(
'liveramp_audiences.incoming_header_order',
1,
expect.arrayContaining([
'test-tag',
'actionConfigId:test-action-config-id',
'destinationConfigId:test-destination-config-id',
'sourceId:test-source-id',
'actionId:test-action-id'
])
)
})

it('should track alphabetical order when flag is enabled', async () => {
const mockStatsClient = {
histogram: jest.fn(),
incr: jest.fn(),
observe: jest.fn(),
_name: '',
_tags: [],
set: jest.fn()
}
const statsContext: StatsContext = { statsClient: mockStatsClient as any, tags: ['test-tag'] }

await testDestination.executeBatch('audienceEnteredS3', {
events: mockedEvents,
mapping: {
s3_aws_access_key: 's3_aws_access_key',
s3_aws_secret_key: 's3_aws_secret_key',
s3_aws_bucket_name: 's3-aws-bucket-name',
s3_aws_region: 's3_aws_region',
audience_key: 'audience_key',
delimiter: ',',
filename: 'filename.csv',
enable_batching: true
},
subscriptionMetadata: {
destinationConfigId: 'test-destination-config-id',
actionConfigId: 'test-action-config-id',
sourceId: 'test-source-id',
actionId: 'test-action-id'
},
settings: {
__segment_internal_engage_force_full_sync: true,
__segment_internal_engage_batch_sync: true
},
features: {
[LIVERAMP_ALPHABETICAL_FIELD_ORDER_FLAG_NAME]: true
},
statsContext
})

expect(mockStatsClient.incr).toHaveBeenCalledWith(
'liveramp_audiences.incoming_header_order',
1,
expect.arrayContaining([
'test-tag',
'actionConfigId:test-action-config-id',
'destinationConfigId:test-destination-config-id',
'sourceId:test-source-id',
'actionId:test-action-id'
])
)
})
})
describe('audienceEnteredSFTP', () => {
it('should send events with valid payload size and events', async () => {
Expand Down Expand Up @@ -417,109 +310,5 @@ describe('Liveramp Audiences', () => {
}
})

it('should track incoming header order metric when statsContext is provided', async () => {
const mockStatsClient = {
histogram: jest.fn(),
incr: jest.fn(),
observe: jest.fn(),
_name: '',
_tags: [],
set: jest.fn()
}
const statsContext: StatsContext = { statsClient: mockStatsClient as any, tags: ['test-tag'] }

await testDestination.executeBatch('audienceEnteredSFTP', {
events: mockedEvents,
mapping: {
sftp_username: 'sftp_username',
sftp_aws_access_key: 'sftp_aws_access_key',
sftp_folder_path: 'sftp_folder_path',
sftp_password: 'sftp_password',
audience_key: 'audience_key',
delimiter: ',',
filename: 'filename.csv',
enable_batching: true,
identifier_data: {
email: { '@path': '$.properties.email' },
first_name: { '@path': '$.properties.first_name' }
}
},
subscriptionMetadata: {
destinationConfigId: 'test-destination-config-id',
actionConfigId: 'test-action-config-id',
sourceId: 'test-source-id',
actionId: 'test-action-id'
},
settings: {
__segment_internal_engage_force_full_sync: true,
__segment_internal_engage_batch_sync: true
},
statsContext
})

expect(mockStatsClient.incr).toHaveBeenCalledWith(
'liveramp_audiences.incoming_header_order',
1,
expect.arrayContaining([
'test-tag',
'actionConfigId:test-action-config-id',
'destinationConfigId:test-destination-config-id',
'sourceId:test-source-id',
'actionId:test-action-id'
])
)
})

it('should track alphabetical order when flag is enabled', async () => {
const mockStatsClient = {
histogram: jest.fn(),
incr: jest.fn(),
observe: jest.fn(),
_name: '',
_tags: [],
set: jest.fn()
}
const statsContext: StatsContext = { statsClient: mockStatsClient as any, tags: ['test-tag'] }

await testDestination.executeBatch('audienceEnteredSFTP', {
events: mockedEvents,
mapping: {
sftp_username: 'sftp_username',
sftp_aws_access_key: 'sftp_aws_access_key',
sftp_folder_path: 'sftp_folder_path',
sftp_password: 'sftp_password',
audience_key: 'audience_key',
delimiter: ',',
filename: 'filename.csv',
enable_batching: true
},
subscriptionMetadata: {
destinationConfigId: 'test-destination-config-id',
actionConfigId: 'test-action-config-id',
sourceId: 'test-source-id',
actionId: 'test-action-id'
},
settings: {
__segment_internal_engage_force_full_sync: true,
__segment_internal_engage_batch_sync: true
},
features: {
[LIVERAMP_ALPHABETICAL_FIELD_ORDER_FLAG_NAME]: true
},
statsContext
})

expect(mockStatsClient.incr).toHaveBeenCalledWith(
'liveramp_audiences.incoming_header_order',
1,
expect.arrayContaining([
'test-tag',
'actionConfigId:test-action-config-id',
'destinationConfigId:test-destination-config-id',
'sourceId:test-source-id',
'actionId:test-action-id'
])
)
})
})
})
Loading
Loading