STRATCONN-6533: remove alphabetical field order flag and related logic#3702
Open
STRATCONN-6533: remove alphabetical field order flag and related logic#3702
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the LiveRamp Audiences “alphabetical field order” feature flag and updates the LiveRamp ingestion file generation/tests to assume headers are always alphabetically sorted.
Changes:
- Removed
LIVERAMP_ALPHABETICAL_FIELD_ORDER_FLAG_NAMEand all related flag plumbing. - Updated
generateFileto always output alphabetically sorted headers and simplified call sites. - Updated LiveRamp Audiences tests to remove the flag and adjust expectations accordingly.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/destination-actions/src/destinations/liveramp-audiences/properties.ts | Removes the alphabetical field order feature flag constant. |
| packages/destination-actions/src/destinations/liveramp-audiences/operations.ts | Updates generateFile to always sort headers; removes incoming-order detection return value. |
| packages/destination-actions/src/destinations/liveramp-audiences/audienceEnteredSftp/index.ts | Removes feature-flag usage; updates metric tagging behavior accordingly. |
| packages/destination-actions/src/destinations/liveramp-audiences/audienceEnteredS3/index.ts | Removes feature-flag usage; updates metric tagging behavior accordingly. |
| packages/destination-actions/src/destinations/liveramp-audiences/tests/operations.test.ts | Updates generateFile calls to the new signature and removes now-obsolete detection tests. |
| packages/destination-actions/src/destinations/liveramp-audiences/tests/liveramp.test.ts | Removes feature-flag references in batch execution tests and adjusts metric assertions. |
packages/destination-actions/src/destinations/liveramp-audiences/operations.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/liveramp-audiences/audienceEnteredS3/index.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/liveramp-audiences/audienceEnteredSftp/index.ts
Outdated
Show resolved
Hide resolved
packages/destination-actions/src/destinations/liveramp-audiences/__tests__/liveramp.test.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@copilot apply changes based on the comments in this thread |
Agent-Logs-Url: https://github.com/segmentio/action-destinations/sessions/8121e152-ee42-42d1-b1b4-152b93309901 Co-authored-by: abhandage <174417010+abhandage@users.noreply.github.com>
Contributor
Applied all changes from the review in commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the Liveramp Audiences destination tests to reflect that alphabetical field ordering is now always enabled, rather than being controlled by a feature flag. The changes remove references to the alphabetical order feature flag from the test files and update test cases and helper function calls accordingly.
Test updates for alphabetical field ordering:
LIVERAMP_ALPHABETICAL_FIELD_ORDER_FLAG_NAMEfeature flag from test imports and test payloads inliveramp.test.ts, reflecting that alphabetical field ordering is now always enabled. [1] [2] [3]Helper function invocation changes:
generateFileinoperations.test.tsto remove the now-unnecessarytrueargument, since alphabetical ordering is always on. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24]Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'New Destination Checklist
verioning-info.tsfile. example