Skip to content

STRATCONN-6533: remove alphabetical field order flag and related logic#3702

Open
abhandage wants to merge 2 commits intomainfrom
cleanup-liveramp-flag
Open

STRATCONN-6533: remove alphabetical field order flag and related logic#3702
abhandage wants to merge 2 commits intomainfrom
cleanup-liveramp-flag

Conversation

@abhandage
Copy link
Copy Markdown
Contributor

This pull request updates the Liveramp Audiences destination tests to reflect that alphabetical field ordering is now always enabled, rather than being controlled by a feature flag. The changes remove references to the alphabetical order feature flag from the test files and update test cases and helper function calls accordingly.

Test updates for alphabetical field ordering:

  • Removed all references to the LIVERAMP_ALPHABETICAL_FIELD_ORDER_FLAG_NAME feature flag from test imports and test payloads in liveramp.test.ts, reflecting that alphabetical field ordering is now always enabled. [1] [2] [3]
  • Updated test descriptions to indicate that alphabetical order is always enabled, and adjusted test payloads to remove the feature flag. [1] [2]

Helper function invocation changes:

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

Security Review

Please ensure sensitive data is properly protected in your integration.

  • Reviewed all field definitions for sensitive data (API keys, tokens, passwords, client secrets) and confirmed they use type: 'password'

New Destination Checklist

  • Extracted all action API versions to verioning-info.ts file. example

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the LiveRamp Audiences “alphabetical field order” feature flag and updates the LiveRamp ingestion file generation/tests to assume headers are always alphabetically sorted.

Changes:

  • Removed LIVERAMP_ALPHABETICAL_FIELD_ORDER_FLAG_NAME and all related flag plumbing.
  • Updated generateFile to always output alphabetically sorted headers and simplified call sites.
  • Updated LiveRamp Audiences tests to remove the flag and adjust expectations accordingly.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
packages/destination-actions/src/destinations/liveramp-audiences/properties.ts Removes the alphabetical field order feature flag constant.
packages/destination-actions/src/destinations/liveramp-audiences/operations.ts Updates generateFile to always sort headers; removes incoming-order detection return value.
packages/destination-actions/src/destinations/liveramp-audiences/audienceEnteredSftp/index.ts Removes feature-flag usage; updates metric tagging behavior accordingly.
packages/destination-actions/src/destinations/liveramp-audiences/audienceEnteredS3/index.ts Removes feature-flag usage; updates metric tagging behavior accordingly.
packages/destination-actions/src/destinations/liveramp-audiences/tests/operations.test.ts Updates generateFile calls to the new signature and removes now-obsolete detection tests.
packages/destination-actions/src/destinations/liveramp-audiences/tests/liveramp.test.ts Removes feature-flag references in batch execution tests and adjusts metric assertions.

@abhandage
Copy link
Copy Markdown
Contributor Author

@copilot apply changes based on the comments in this thread

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 30, 2026

@copilot apply changes based on the comments in this thread

Applied all changes from the review in commit 3cf316c:

  • operations.ts: Replaced the two stale comments that referenced feature-flag logic and "check if incoming headers are already alphabetical" with a single accurate comment: // Sort headers alphabetically, keeping audience_key first.
  • audienceEnteredS3/index.ts & audienceEnteredSftp/index.ts: Removed the liveramp_audiences.incoming_header_order metric entirely — it was incrementing without any order: tag (since isIncomingAlphabetical was removed), making it meaningless for tracking header order.
  • liveramp.test.ts: Removed the four stale tests that were asserting on that metric (two for S3, two for SFTP), and dropped the now-unused StatsContext import.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants