-
Notifications
You must be signed in to change notification settings - Fork 306
batch 7: refactor API versioning to use versioning-info module #3701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abhandage
wants to merge
2
commits into
main
Choose a base branch
from
batch-7
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
packages/destination-actions/src/destinations/amazon-conversions-api/versioning-info.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| /** AMAZON_CONVERSIONS_API_PROFILES_VERSION | ||
| * Profiles endpoint version: /v2/profiles | ||
| * API reference: https://advertising.amazon.com/API/docs/en-us/reference/2/profiles#tag/Profiles/operation/listProfiles | ||
| */ | ||
| export const AMAZON_CONVERSIONS_API_PROFILES_VERSION = 'v2' | ||
|
|
||
| /** AMAZON_CONVERSIONS_API_EVENTS_VERSION | ||
| * Events endpoint version: /v1/events | ||
| * API reference: https://advertising.amazon.com/API/docs/en-us/amazon-ads/1-0/betas#tag/Events/operation/CreateEvent | ||
| */ | ||
| export const AMAZON_CONVERSIONS_API_EVENTS_VERSION = 'v1' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/destination-actions/src/destinations/avo/versioning-info.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| /** AVO_API_VERSION | ||
| * Inspector track endpoint version. | ||
| * API reference: https://www.avo.app/docs/implementation/devs-101#inspector-api | ||
| */ | ||
| export const AVO_API_VERSION = 'v1' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/destination-actions/src/destinations/engage-messaging-sendgrid/versioning-info.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| /** ENGAGE_MESSAGING_SENDGRID_API_VERSION | ||
| * SendGrid mail send API version. | ||
| * API reference: https://docs.sendgrid.com/api-reference/mail-send/mail-send | ||
| */ | ||
| export const ENGAGE_MESSAGING_SENDGRID_API_VERSION = 'v3' |
6 changes: 4 additions & 2 deletions
6
packages/destination-actions/src/destinations/facebook-custom-audiences/constants.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
packages/destination-actions/src/destinations/facebook-custom-audiences/versioning-info.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| /** FACEBOOK_CUSTOM_AUDIENCES_API_VERSION | ||
| * Facebook Custom Audiences API version. | ||
| * API reference: https://developers.facebook.com/docs/marketing-api/audiences/guides/custom-audiences | ||
| */ | ||
| export const FACEBOOK_CUSTOM_AUDIENCES_API_VERSION = 'v24.0' | ||
|
|
||
| /** FACEBOOK_CUSTOM_AUDIENCES_CANARY_API_VERSION | ||
| * Facebook Custom Audiences API canary version. | ||
| * API reference: https://developers.facebook.com/docs/marketing-api/audiences/guides/custom-audiences | ||
| */ | ||
| export const FACEBOOK_CUSTOM_AUDIENCES_CANARY_API_VERSION = 'v24.0' | ||
abhandage marked this conversation as resolved.
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/destination-actions/src/destinations/google-sheets/versioning-info.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| /** GOOGLE_SHEETS_API_VERSION | ||
| * Google Sheets API version. | ||
| * API reference: https://developers.google.com/workspace/sheets/api/reference/rest | ||
| */ | ||
| export const GOOGLE_SHEETS_API_VERSION = 'v4' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/destination-actions/src/destinations/taboola-actions/versioning-info.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| /** TABOOLA_API_VERSION | ||
| * Taboola Backstage API version. | ||
| * API reference: https://developers.taboola.com/backstage-api/reference/create-a-first-party-audience | ||
| */ | ||
| export const TABOOLA_API_VERSION = '1.0' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/destination-actions/src/destinations/tiktok-offline-conversions/versioning-info.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| /** TIKTOK_OFFLINE_CONVERSIONS_API_VERSION | ||
| * TikTok offline conversions API version. | ||
| * API reference: https://business-api.tiktok.com/portal/docs?id=1758428013689857 | ||
| */ | ||
| export const TIKTOK_OFFLINE_CONVERSIONS_API_VERSION = 'v1.3' |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.