Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors several destination integrations to standardize API version management by centralizing version strings into versioning-info.ts modules and updating request URL construction to reference those constants. This reduces scattered hardcoded versions and makes future version bumps more maintainable.
Changes:
- Added
versioning-info.tsmodules exporting API version constants for multiple destinations. - Replaced hardcoded API version segments in endpoint URLs with imported constants.
- Minor formatting/whitespace cleanup in a few touched files.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/destination-actions/src/destinations/tiktok-offline-conversions/versioning-info.ts | Introduces centralized TikTok Offline Conversions API version constant. |
| packages/destination-actions/src/destinations/tiktok-offline-conversions/utils.ts | Uses centralized API version when constructing track endpoint URL. |
| packages/destination-actions/src/destinations/tiktok-offline-conversions/index.ts | Uses centralized API version for auth test endpoint URL; adds a named export. |
| packages/destination-actions/src/destinations/taboola-actions/versioning-info.ts | Introduces centralized Taboola Backstage API version constant. |
| packages/destination-actions/src/destinations/taboola-actions/syncAudience/client.ts | Uses centralized API version in audience onboarding URL. |
| packages/destination-actions/src/destinations/taboola-actions/index.ts | Uses centralized API version in create audience onboarding URL. |
| packages/destination-actions/src/destinations/google-sheets/versioning-info.ts | Introduces centralized Google Sheets API version constant. |
| packages/destination-actions/src/destinations/google-sheets/googleapis/index.ts | Uses centralized API version for Sheets REST endpoints. |
| packages/destination-actions/src/destinations/facebook-custom-audiences/versioning-info.ts | Adds version constants for Facebook Custom Audiences (currently not wired into the destination). |
| packages/destination-actions/src/destinations/engage-messaging-sendgrid/versioning-info.ts | Introduces centralized SendGrid API version constant. |
| packages/destination-actions/src/destinations/engage-messaging-sendgrid/sendEmail/SendEmailPerformer.ts | Uses centralized API version in mail send endpoint URL. |
| packages/destination-actions/src/destinations/engage-messaging-sendgrid/index.ts | Uses centralized API version in auth test endpoint URL. |
| packages/destination-actions/src/destinations/avo/versioning-info.ts | Introduces centralized AVO Inspector endpoint version constant. |
| packages/destination-actions/src/destinations/avo/sendSchemaToInspector/index.ts | Uses centralized API version in Inspector track endpoint URL. |
| packages/destination-actions/src/destinations/amazon-conversions-api/versioning-info.ts | Introduces centralized versions for Amazon profiles/events endpoints. |
| packages/destination-actions/src/destinations/amazon-conversions-api/trackConversion/utils.ts | Uses centralized events endpoint version in request URL; minor formatting cleanup. |
| packages/destination-actions/src/destinations/amazon-conversions-api/index.ts | Uses centralized profiles endpoint version in auth test request URL; minor formatting cleanup. |
packages/destination-actions/src/destinations/amazon-conversions-api/index.ts
Show resolved
Hide resolved
packages/destination-actions/src/destinations/facebook-custom-audiences/versioning-info.ts
Show resolved
Hide resolved
packages/destination-actions/src/destinations/google-sheets/googleapis/index.ts
Show resolved
Hide resolved
packages/destination-actions/src/destinations/tiktok-offline-conversions/index.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a standardized approach to managing API versioning across several destination integrations by extracting API version strings into dedicated constants and updating endpoint construction to use these constants. This improves maintainability and consistency when updating API versions in the future. Additionally, new versioning info files are added for each integration, and some minor formatting improvements are made.
The most important changes are:
API Versioning Standardization
versioning-info.ts) for Amazon Conversions API, AVO Inspector, Engage Messaging SendGrid, Facebook Custom Audiences, Google Sheets, and Taboola integrations, each exporting a constant for the relevant API version. [1] [2] [3] [4] [5]Amazon Conversions API Improvements
versioning-info.tsand updated theprofilesandeventsendpoint URLs to use version constants, aligning with API documentation and simplifying future upgrades. [1] [2] [3]Other Integrations
Documentation and Maintainability
Minor Cleanups
These changes collectively make the integrations more robust, easier to maintain, and ready for future API version upgrades.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'New Destination Checklist
verioning-info.tsfile. example