-
Notifications
You must be signed in to change notification settings - Fork 306
batch-6: refactor API versioning to use versioning-info module #3700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abhandage
wants to merge
1
commit into
main
Choose a base branch
from
batch-6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
packages/destination-actions/src/destinations/first-party-dv360/versioning-info.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| /** FIRST_PARTY_DV360_API_VERSION | ||
| * DV360 First Party Audience API version. | ||
| * API reference: https://developers.google.com/display-video/api/reference/rest/v4/firstPartyAndPartnerAudiences/create | ||
| */ | ||
| export const FIRST_PARTY_DV360_API_VERSION = 'v4' | ||
|
|
||
| /** FIRST_PARTY_DV360_CANARY_API_VERSION | ||
| * DV360 First Party Audience API canary version. | ||
| * API reference: https://developers.google.com/display-video/api/reference/rest/v4/firstPartyAndPartnerAudiences/create | ||
| */ | ||
| export const FIRST_PARTY_DV360_CANARY_API_VERSION = 'v4' |
4 changes: 3 additions & 1 deletion
4
packages/destination-actions/src/destinations/rokt-audiences/constants.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/destination-actions/src/destinations/rokt-audiences/versioning-info.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| /** ROKT_API_VERSION | ||
| * Rokt audiences API version. | ||
| * API reference: https://docs.rokt.com/developers/api-reference/custom-audience-import | ||
| */ | ||
| export const ROKT_API_VERSION = 'v3' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/destination-actions/src/destinations/segment-profiles/versioning-info.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| /** SEGMENT_PROFILES_API_VERSION | ||
| * Segment Profiles API version. | ||
| * API reference : https://docs.segmentapis.com/tag/Audiences | ||
| */ | ||
| export const SEGMENT_PROFILES_API_VERSION = 'v1' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/destination-actions/src/destinations/talon-one/versioning-info.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| /** TALON_ONE_API_VERSION | ||
| * Talon.One integration API version. | ||
| * API reference : https://docs.talon.one/integration-api/ | ||
abhandage marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| */ | ||
| export const TALON_ONE_API_VERSION = 'v2' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
packages/destination-actions/src/destinations/yahoo-audiences/versioning-info.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| /** YAHOO_AUDIENCES_TAXONOMY_API_VERSION | ||
| * Yahoo Audiences taxonomy API version. | ||
| * API reference: https://help.yahooinc.com/datax/docs/put-append-taxonomy-node | ||
| */ | ||
| export const YAHOO_AUDIENCES_TAXONOMY_API_VERSION = 'v1' | ||
abhandage marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.