Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Centralizes per-destination API version strings into versioning-info.ts modules and updates affected destinations to construct request URLs from those shared constants, reducing scattered hardcoded versions across the Action Destinations codebase.
Changes:
- Added new
versioning-info.tsfiles exporting destination-specific API version constants. - Updated multiple destinations’ URL construction to interpolate the centralized version constants.
- Adjusted DV360 helpers to source
API_VERSION/CANARY_API_VERSIONfrom the new module.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/destination-actions/src/destinations/yahoo-audiences/versioning-info.ts | Adds centralized Yahoo Audiences version constant. |
| packages/destination-actions/src/destinations/yahoo-audiences/utils-tax.ts | Uses centralized version constant in taxonomy/auth endpoint URLs. |
| packages/destination-actions/src/destinations/yahoo-audiences/utils-rt.ts | Uses centralized version constant in ZTS URL for JWT audience. |
| packages/destination-actions/src/destinations/talon-one/versioning-info.ts | Adds centralized Talon.One API version constant. |
| packages/destination-actions/src/destinations/talon-one/updateCustomerSessionV2/index.ts | Replaces hardcoded /v2 with version constant in request URL. |
| packages/destination-actions/src/destinations/talon-one/updateCustomerProfileV3/index.ts | Replaces hardcoded /v2 with version constant in request URL. |
| packages/destination-actions/src/destinations/talon-one/trackEventV2/index.ts | Replaces hardcoded /v2 with version constant in request URL. |
| packages/destination-actions/src/destinations/segment-profiles/versioning-info.ts | Adds centralized Segment Profiles API version constant. |
| packages/destination-actions/src/destinations/segment-profiles/properties.ts | Uses version constant for regional Segment endpoints (api/cdn). |
| packages/destination-actions/src/destinations/rokt-audiences/versioning-info.ts | Adds centralized Rokt Audiences API version constant. |
| packages/destination-actions/src/destinations/rokt-audiences/constants.ts | Uses version constant in Rokt base URL. |
| packages/destination-actions/src/destinations/first-party-dv360/versioning-info.ts | Adds centralized DV360 API + canary version constants. |
| packages/destination-actions/src/destinations/first-party-dv360/functions.ts | Sources exported API version values from the new versioning module. |
packages/destination-actions/src/destinations/yahoo-audiences/versioning-info.ts
Show resolved
Hide resolved
packages/destination-actions/src/destinations/talon-one/versioning-info.ts
Show resolved
Hide resolved
packages/destination-actions/src/destinations/segment-profiles/versioning-info.ts
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request centralizes API version management for several destinations by moving API version constants into dedicated
versioning-info.tsfiles and updating all relevant URL constructions to use these constants. This makes it easier to update API versions in the future and improves code maintainability and clarity.Key changes by theme:
API Version Centralization
versioning-info.tsfiles for the following destinations, each exporting a single source of truth for the API version:FIRST_PARTY_DV360_API_VERSION,FIRST_PARTY_DV360_CANARY_API_VERSION)ROKT_API_VERSION)SEGMENT_PROFILES_API_VERSION)TALON_ONE_API_VERSION)YAHOO_AUDIENCES_TAXONOMY_API_VERSION)URL Construction Updates
functions.ts)constants.ts)properties.ts) [1] [2]trackEventV2/index.ts,updateCustomerProfileV3/index.ts,updateCustomerSessionV2/index.ts) [1] [2] [3] [4] [5] [6]utils-rt.ts,utils-tax.ts) [1] [2] [3] [4]Maintainability Improvements
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.
Security Review
Please ensure sensitive data is properly protected in your integration.
type: 'password'New Destination Checklist
verioning-info.tsfile. example