Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inline spacing treatment, using modern CSS features #357

Merged
merged 8 commits into from
Jun 4, 2024

Conversation

felixhabib
Copy link
Contributor

@felixhabib felixhabib commented Jun 3, 2024

Taking advantage of modern CSS spacing features for a better dev experience. This change:

  • Adds a small size to the spacing scale (6px) and increases medium spacing to 8px
  • Converts all existing uses of medium spacing to small spacing
  • Updates the Inline component to:
    • use gap for spacing,
    • use the space scale from sprinkles, and
    • include an alignY prop
  • Replaces uses of horizontal padding with flex gap on inline elements (using the Inline component or CSS where appropriate)
  • Uses a 3 column grid for keyboard shortcut key arrangement
  • Replaces vertical padding in Frame Panel with Stack spacing

Using the changeset from #355 as this work is related.

@felixhabib felixhabib requested a review from a team as a code owner June 3, 2024 02:28
Copy link

changeset-bot bot commented Jun 3, 2024

⚠️ No Changeset found

Latest commit: 1045305

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
playroom Minor

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@felixhabib felixhabib changed the title Update Inline spacing treatment, using modern CSS features Update inline spacing treatment, using modern CSS features Jun 3, 2024
@felixhabib felixhabib merged commit bbd33df into master Jun 4, 2024
11 checks passed
@felixhabib felixhabib deleted the flex-gap-inline branch June 4, 2024 02:01
@felixhabib felixhabib mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants