Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Box component #359

Merged
merged 6 commits into from
Jun 6, 2024
Merged

Add Box component #359

merged 6 commits into from
Jun 6, 2024

Conversation

felixhabib
Copy link
Contributor

@felixhabib felixhabib commented Jun 5, 2024

This change:

  • Moves vars into its own file (from sprinkles.css.ts)
  • Adds a Box component, getting props from sprinkles
  • Adds auto as a margin space option in sprinkles
  • Uses Box in place of flexGrow and margin: auto for layout where appropriate
  • Removes unused classes in Toolbar.css.ts

Continuing the work from #357 and #355 so will share the same changeset

@felixhabib felixhabib requested a review from a team as a code owner June 5, 2024 04:39
Copy link

changeset-bot bot commented Jun 5, 2024

⚠️ No Changeset found

Latest commit: 26418e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@felixhabib felixhabib merged commit 7176790 into master Jun 6, 2024
6 checks passed
@felixhabib felixhabib deleted the add-box-component branch June 6, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants