Allow specifying defaults for visible themes and widths #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ff0a443 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@michaeltaranto any chance you can have a look over this one? We support about 20 different themes across ~6 different screen sizes. Initially loading all of these is very overwhelming and we would love to specifying defaults to prevent this cognitive overload. |
michaeltaranto
approved these changes
Feb 13, 2024
|
This feature is great, thanks for the PR, just a small note, it could be worth to mention in the readme that to the defaultVisibleThemes you don't pass the theme object but just the theme name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying default screen sizes and themes to be rendered when a state is not found in the query string or from being already specified in the StoreProvider react context.
Addresses: #176