Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ add new config variable "defaultWidths" #302

Closed
wants to merge 1 commit into from

Conversation

JulianNymark
Copy link

@JulianNymark JulianNymark commented Nov 16, 2023

What and Why?

Allow default widths to be set to something other than "show all the widths available", since we support a lot of breakpoints, but for the average developer using our design system it's a bit overwhelming to see all of them + horizontal scroll when they are usually just interested in one or two breakpoints (for us it's usually a mobile width + generic desktop widths).

image

How?

introduces a configuration variable defaultWidths that becomes the viewports rendered when you have no width check mark selected in the sidebar (as shown in the screenshot above).

module.exports = {
  // ...
  widths: [320, 480, 768, 1024, 1280, 1440],
  defaultWidths: [320, 1280]
};

@JulianNymark JulianNymark requested a review from a team as a code owner November 16, 2023 11:09
Copy link

changeset-bot bot commented Nov 16, 2023

⚠️ No Changeset found

Latest commit: e6c806a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@michaeltaranto
Copy link
Contributor

Addressed by #305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants