Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocompleting tags #7

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Autocompleting tags #7

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e03e075
added new version of JQuery plus CSS/images
makoshark Nov 7, 2011
04b0f54
added Thomas Niepraschk's tag autocomplete feature
makoshark Nov 7, 2011
a4d4c86
fixed missing quotes around mp3
makoshark Nov 8, 2011
72c7cbb
Revert Thomas Niepraschk's tag autocomplete feature (3 commits)
makoshark Apr 8, 2012
7e8b3ec
added jQuery UI autocomplete to the tags field when editing a bookmark
Feb 16, 2011
b1bb03e
improve the perfromance of the javascript autocomplete lookup
makoshark Apr 8, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed missing quotes around mp3 
In my system, with JQuery 1.5, the previous two commits caused *every*
link to load the Flash MP3 mplayer, even though none of these were
playable. This patch fixes that issue.

The issue, as far as I can tell, seems to be due to a change in the
version of JQuery. But I have only looked close enough to fix the bug.
@makoshark
makoshark committed Nov 8, 2011
commit a4d4c86c4488d333371f121f3aefc989ba1270ee
2 changes: 1 addition & 1 deletion jsScuttle.php
View file
Original file line number Diff line number Diff line change
@@ -116,7 +116,7 @@ function extractLast( term ) {

// Insert Flash player for MP3 links
if ($("#bookmarks").length > 0) {
$("a[href$=.mp3].taggedlink").each(function() {
$('a[href$=".mp3"].taggedlink').each(function() {
var url = this.href;
var code = '<object type="application/x-shockwave-flash" data="<?php echo $player_root ?>musicplayer_f6.swf?song_url=' + url +'&amp;b_bgcolor=ffffff&amp;b_fgcolor=000000&amp;b_colors=0000ff,0000ff,ff0000,ff0000&buttons=<?php echo $player_root ?>load.swf,<?php echo $player_root ?>play.swf,<?php echo $player_root ?>stop.swf,<?php echo $player_root ?>error.swf" width="14" height="14">';
code = code + '<param name="movie" value="<?php echo $player_root ?>musicplayer.swf?song_url=' + url +'&amp;b_bgcolor=ffffff&amp;b_fgcolor=000000&amp;b_colors=0000ff,0000ff,ff0000,ff0000&amp;buttons=<?php echo $player_root ?>load.swf,<?php echo $player_root ?>play.swf,<?php echo $player_root ?>stop.swf,<?php echo $player_root ?>error.swf" />';