Autocompleting tags #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new version of JQuery (1.5) is required by Thomas Niepraschk's patch adding autocomplete support.
The work in this patch is taken from the following GH repository: https://github.com/niepi/scuttle-autocomplete The work is Copyright (c) Thomas Niepraschk 2011. Niepraschk's work is not done as a branch to the scuttle git repository, includes a series of unrelated changes, and involves a few mistakes. In this branch, I've provided a clean-up of his work but very little of my own. I have made the following change over what Thomas did in his repository: - Reverted the move of config.inc.php from config.inc.php.example - Changed the script code to not include simple load JQuery from googleapis.com (introducing some privacy issues) but to load it from the copies that Thomas included in the repository instead. - I have also removed from the history several extra files including the full dump of his database (!) which he them removed in a subsequent commit. All credit goes to Thomas Niepraschk for his hard work to build the functionality. I use it and love it!
In my system, with JQuery 1.5, the previous two commits caused *every* link to load the Flash MP3 mplayer, even though none of these were playable. This patch fixes that issue. The issue, as far as I can tell, seems to be due to a change in the version of JQuery. But I have only looked close enough to fix the bug.
This was performing poorly on large lists. The delay can be set down very low because the list is stored entirely in memory. The current code only does the lookup when there are >2 characters typed in for a particular tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common problem when you are trying to add new bookmarks into a Scuttle system is that you do not realize which tags already exist. Ajax auto-completion of tags helps address this issue very nicely and has been present in Delicious and most of the proprietary competitors for some time.
Thomas Niepraschk created a pretty awesome [https://github.com/niepi/scuttle-autocomplete/](set of patches) on top of Scuttle 0.9.0 (which is imported directly from a tarball). I've done a some work to clean his patch up, split it into distinct commits and fix a bug in it. Anyway, I think it's ready in its current state to be merged into the main version of Scuttle.