Skip to content

Use local install for release docs #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2025
Merged

Use local install for release docs #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:
default: false
type: boolean
version:
description: 'Version of ScippNeutron to use for building the docs. Requires this version to be available on conda-forge! If not set, the current version will be used.'
default: ''
required: false
type: string
Expand All @@ -21,6 +22,7 @@ on:
default: false
type: boolean
version:
description: 'Version of ScippNeutron to use for building the docs. Requires this version to be available on conda-forge! If not set, the current version will be used.'
Copy link
Member

@nvaytet nvaytet Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, why don't we make a conda env without scippneutron in all cases, and then pip install either locally from source or using the specified version from Pypi if version is defined?

Copy link
Member Author

@jl-wynen jl-wynen Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might work as long as we don't install PyPI dependencies. But why would that be better?

Copy link
Member

@nvaytet nvaytet Nov 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I slightly misunderstood.
I see we are installing a whole bunch of things from the environment file .buildconfig/ci-linux.yml anyway.
I guess what you have here is fine.

default: ''
required: false
type: string
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ jobs:
uses: ./.github/workflows/docs.yml
with:
publish: ${{ github.event_name == 'release' && github.event.action == 'published' }}
version: ${{ github.event.release.tag_name }}
Copy link
Member

@nvaytet nvaytet Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this now looks like what we have in the other packages, right?
I wonder why we had that difference in the first place...

Copy link
Member Author

@jl-wynen jl-wynen Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legacy from using conda?

secrets: inherit

assets:
Expand Down
Loading