Use local install for release docs #652
Conversation
| default: false | ||
| type: boolean | ||
| version: | ||
| description: 'Version of ScippNeutron to use for building the docs. Requires this version to be available on conda-forge! If not set, the current version will be used.' |
There was a problem hiding this comment.
Hmm, why don't we make a conda env without scippneutron in all cases, and then pip install either locally from source or using the specified version from Pypi if version is defined?
There was a problem hiding this comment.
That might work as long as we don't install PyPI dependencies. But why would that be better?
There was a problem hiding this comment.
I think I slightly misunderstood.
I see we are installing a whole bunch of things from the environment file .buildconfig/ci-linux.yml anyway.
I guess what you have here is fine.
| uses: ./.github/workflows/docs.yml | ||
| with: | ||
| publish: ${{ github.event_name == 'release' && github.event.action == 'published' }} | ||
| version: ${{ github.event.release.tag_name }} |
There was a problem hiding this comment.
So this now looks like what we have in the other packages, right?
I wonder why we had that difference in the first place...
There was a problem hiding this comment.
Legacy from using conda?
This should fix the broken docs build in a release (https://github.com/scipp/scippneutron/actions/runs/19627948536/job/56200774373)
I left the
versionparameter so that we can still select a different version if we need to patch up the docs later. But the release build no longer depends on