Skip to content

Error in VCF test files #860

Description

@markwoon

Several failed/ conformance fixtures under test/vcf/{4.1,4.2,4.3}/ use
##CauseOfFailure=Non-valid URL for an ##assembly=/##pedigreeDB= value whose only
distinguishing feature is a numeric-looking hostname (8080): ftp://8080:8080/not-valid/host/to/file.fastq

That string is syntactically valid per RFC 3986 (a reg-name may be all-digits) and passes all URL validators I tried (python, java, online validators).

Are these tests supposed to fail because the URL is syntactically invalid, or that it doesn't actually point to anything? I'm guessing the former since it says not-valid/host and I don't the parser should be expected to make a network call to test the URL.

Affected fixtures

##assembly=ftp://8080:8080/not-valid/host/to/file.fastq

File ##fileformat= ##CauseOfFailure=
test/vcf/4.1/failed/failed_meta_assembly_001.vcf VCFv4.1 Non-valid URL
test/vcf/4.2/failed/failed_meta_assembly_001.vcf VCFv4.3 Meta-data entry is not a key-value pair
test/vcf/4.3/failed/failed_meta_assembly_001.vcf VCFv4.3 Meta-data entry is not a key-value pair

Note: test/vcf/4.2/failed/failed_meta_assembly_001.vcf lives under the 4.2/ directory but internally declares VCFv4.3.

##pedigreeDB=ftp://8080:8080/not-valid/host/to/pedigreeDB

File ##fileformat= ##CauseOfFailure=
test/vcf/4.1/failed/failed_meta_pedigreedb_002.vcf VCFv4.1 Non-valid URL
test/vcf/4.2/failed/failed_meta_pedigreedb_002.vcf VCFv4.2 Non-valid URL
test/vcf/4.3/failed/failed_meta_pedigreedb_002.vcf VCFv4.3 Non-valid URL

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions